Feature/stop promoting trials of hidden plans #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swashata
requested changes
Mar 12, 2024
There was a problem hiding this comment.
@DanieleAlessandra great job on your first PR 👏 .. Please see the code convention and formatting thingies and we can get this merged. Thanks.
swashata
approved these changes
Mar 27, 2024
swashata
requested changes
Mar 27, 2024
There was a problem hiding this comment.
@DanieleAlessandra PR is approved. We just need to bump the version in start.php. Currently it is $this_sdk_version = '2.6.2.1';, please bump it to next pre-release $this_sdk_version = '2.6.2.2';. Then we can squash + merge your PR.
…in_Plan`. Added `get_filtered_plans`and `get_visible_trial_plans` to `FS_Plan_Manager`. Modified `_add_trial_notice` in `Freemius` to use only visible plan with trials.
DanieleAlessandra
force-pushed
the
feature/stop-promoting-trials-of-hidden-plans
branch
from
dbeb8af to
c5d6acb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR by Daniele: https://app.asana.com/0/21269872416169/1206533031904994/f