Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remake/Update of all my previous boards. #273

Merged
merged 22 commits into from
Feb 2, 2025

Conversation

CarCar101
Copy link
Contributor

@CarCar101 CarCar101 commented Jan 30, 2025

Palm Brinks slightly stutters during balloonport and Colony 4 has a big stuttering during balloonport. The rest of boards have no stuttering on balloonport.
Tested on Emulator.

Palm Brinks has a small stuttering during balloonport test, Colony 4 has big stuttering during balloonport test. All boards tested on a emulator
@Sophilautia
Copy link
Collaborator

Found 1 issue(s):

../_maps/Sandsea/Sandsea.yaml - 1 issue(s):
The webp file Sandsea does not exist

(The file is called Sanse.webp)

@Sophilautia
Copy link
Collaborator

We also recommend updating your boards that use switches to use the "fixed" variants of backgrounds. You can find them on here: https://fortunestreetmodding.github.io/backgrounds

@Sophilautia
Copy link
Collaborator

What's the state of the balloonport tests with this PR?

@CarCar101
Copy link
Contributor Author

Found 1 issue(s):

../_maps/Sandsea/Sandsea.yaml - 1 issue(s): The webp file Sandsea does not exist

(The file is called Sanse.webp)

I fixed it. How i do edit the pull request to include those changes?

@CarCar101
Copy link
Contributor Author

CarCar101 commented Jan 30, 2025

We also recommend updating your boards that use switches to use the "fixed" variants of backgrounds. You can find them on here: https://fortunestreetmodding.github.io/backgrounds

I added the fixed background to the Agency as it uses Alltrades Abbey. Palm Brinks has Delfino Plaza which i could not find a fixed version. The rest of the boards have no switches.

@CarCar101
Copy link
Contributor Author

What's the state of the balloonport tests with this PR?

Im not sure what "PR" means, sorry.

@Sophilautia
Copy link
Collaborator

PR as in Pull Request. You need to commit these updates to your own fork of the repository and push them.

@CarCar101
Copy link
Contributor Author

CarCar101 commented Jan 30, 2025

PR as in Pull Request. You need to commit these updates to your own fork of the repository and push them.

I'm not sure if i did it correctly (I'm new at Github) but i updated the new files in my fork, with the Sandsea.webp for Sandsea and bg108fixed for Agency. I am not allowed to delete the old sandse.webp for some reason.

As for the balloonport tests, i did not experiencie any stuttering in any board i updated except Palm Brinks and Colony 4. Palm Brinks has a small stutter (altrough idk if it's less than 1s, probably not) and Colony 4 does have a big stutter on Balloonports. Enne-San told me that if a board has less than 1s stuttering it passes the tests anywys. Colony 4 does not pass the test im sure eitherway.

@Sophilautia
Copy link
Collaborator

Sophilautia commented Feb 2, 2025

Not sure why you wouldn't be allowed to delete sandse.webp, it's your fork. Can you rename it at least?

@CarCar101
Copy link
Contributor Author

Not sure why you wouldn't be allowed to delete sandse.webp, it's your fork. Can you rename it at least?

I deleted them. Sorry i was looking at the wrong option lol.

@Sophilautia
Copy link
Collaborator

Sophilautia commented Feb 2, 2025

It looks like the changelogs could use some work. Can you make sure they're all updated and accurate?

@Sophilautia
Copy link
Collaborator

Pretty sure changelogs are the last thing that needs fixing and we should be good to merge

@CarCar101
Copy link
Contributor Author

CarCar101 commented Feb 2, 2025

Pretty sure changelogs are the last thing that needs fixing and we should be good to merge

Okay. I added "Remade Board" as the change and a new version to each board.

@Sophilautia Sophilautia merged commit d18fb74 into FortuneStreetModding:main Feb 2, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants