feat: Performance analysis tooling #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # evita_engine/src/main/java/io/evitadb/core/Catalog.java # evita_engine/src/main/java/io/evitadb/core/EntityCollection.java # evita_engine/src/main/java/io/evitadb/core/EvitaSession.java # evita_engine/src/main/java/io/evitadb/core/query/QueryPlan.java # evita_engine/src/main/java/module-info.java # evita_external_api/evita_external_api_grpc/shared/src/main/java/io/evitadb/externalApi/grpc/generated/GrpcEntityReference.java # evita_external_api/evita_external_api_grpc/shared/src/main/java/io/evitadb/externalApi/grpc/generated/GrpcEntityReferenceWithParent.java # evita_external_api/evita_external_api_grpc/shared/src/main/java/io/evitadb/externalApi/grpc/generated/GrpcEvitaSessionAPI.java # evita_external_api/evita_external_api_grpc/shared/src/main/java/io/evitadb/externalApi/grpc/generated/GrpcPrice.java # evita_external_api/evita_external_api_grpc/shared/src/main/java/io/evitadb/externalApi/grpc/generated/GrpcUpsertPriceMutation.java
# Conflicts: # evita_api/src/main/java/io/evitadb/api/EntityCollectionContract.java # evita_engine/src/main/java/io/evitadb/core/Catalog.java # evita_engine/src/main/java/io/evitadb/core/EntityCollection.java # evita_engine/src/main/java/io/evitadb/core/EvitaSession.java # evita_external_api/evita_external_api_grpc/shared/src/main/java/io/evitadb/externalApi/grpc/generated/GrpcAttributeSchema.java # evita_external_api/evita_external_api_grpc/shared/src/main/java/io/evitadb/externalApi/grpc/generated/GrpcEntitySchemaMutation.java # evita_external_api/evita_external_api_grpc/shared/src/main/java/io/evitadb/externalApi/grpc/generated/GrpcReferenceSchema.java # evita_external_api/evita_external_api_grpc/shared/src/main/java/io/evitadb/externalApi/grpc/generated/GrpcReferenceSchemaMutations.java # evita_external_api/evita_external_api_grpc/shared/src/main/java/io/evitadb/externalApi/grpc/generated/GrpcSetReferenceSchemaFacetedMutation.java # evita_external_api/evita_external_api_grpc/shared/src/main/java/io/evitadb/externalApi/grpc/generated/GrpcSetReferenceSchemaIndexedMutation.java
…nd traffic recording
… and documentation
Added tests, parsing logic, documentation. Labels are attached to tracing spans and JFR events automatically. Also are serialized along with the query to traffic recording. Refs: #298
Introduced API for source query recording and relations between source query and internal sub-queries. Refs: #298
Introduced API for source query recording and relations between source query and internal sub-queries. Added serializers and tests for them. Refs: #298
API is also implemented but not tested. Refs: #298
# Conflicts: # evita_api/src/main/java/io/evitadb/api/requestResponse/EvitaRequest.java
The entire traffic recording gRPC API was moved to separate service. Refs: #298
…' into 298-performance-analysis-tooling
AAdded client IP to the labels. Refs: #298
Refs: #298
… type attributes
The query:
```graphQL
query {
queryProduct(
filterBy: {
entityLocaleEquals: en
attributeUrlInactiveStartsWith: "/"
}
) {
recordPage {
data {
primaryKey
attributes {
url
}
}
}
}
}
```
Doesn't work on demo schema since the `urlInactive` is string array.
Refs: #778
Refs: #298
# Conflicts: # .github/workflows/ci-master.yml
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to extend evitaLab with a new view that would list all recent requests and queries / mutations executed within them and visualise them in a comprehensible way. This tooling will build on a new facility in evitaDB that allows to store executed queries in the file log and aggregate them with mutations in WAL and provide the tooling with an aggregated view over them.
We know from previous experience that such tools are crucial for the development of high performance applications. Developers make many errors (often N+1 errors) that are difficult to track without such tools. When the list of all queries to the database is visible and can be traced back to a particular page/request, developers can much better reason about the problems.