Deviate from ruby/pretty_print and enrich the API #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Am1ne77
reviewed
Jan 3, 2025
Comment on lines
+212
to
+213
| case delim | ||
| in nil then ['', ''] | ||
| in String | Symbol then [delim, delim] | ||
| in Array then delim.values_at(0, 1).map(&:to_s) | ||
| end |
There was a problem hiding this comment.
Maybe we should extract this part to mixins since we have meen using it twice.
| @@ -9,13 +9,13 @@ | |||
| # By using a callable: | |||
| space = ->(n) { '---' * n } | |||
|
|
|||
| printer = Oppen::Wadler.new(space: space) | |||
| printer = Oppen::Wadler.new(indent: 2, space: space) | |||
Comment on lines
+8
to
+9
| printer_width_default = Oppen::Wadler.new(indent: 2) | ||
| printer_width_narrow = Oppen::Wadler.new(indent: 2, width: width) |
lib/wadler/print.rb
Outdated
Comment on lines
7
to
9
| # @return [Integer] | ||
| # the starting indentation level for the whole printer. | ||
| attr_reader :base_indent |
There was a problem hiding this comment.
You never set the value of @base_indent. Maybe you intended a getter for @indent.
There was a problem hiding this comment.
That's wrong indeed. base indent is current indent. Maybe we should also kill the setter. It doesn't make sense.
Comment on lines
+39
to
+37
| # @param indent [Integer] | ||
| # the default indentation amount for {group} and {nest}. |
There was a problem hiding this comment.
Despite being longer, I would much rather go with default_indent. We can live with indent if you find it too long.
Makes for a simpler, more declarative API.
It's still there since project initialization.
They're _"aliases"_ to `group`.
stackmystack
force-pushed
the
rich-api
branch
2 times, most recently
from
4a10fd0 to
39e72cc
Compare
Am1ne77
force-pushed
the
rich-api
branch
2 times, most recently
from
7fa5121 to
9fbc705
Compare
Which makes chaining calls possible => better looking programs
This is in preparation for the next commit which introduces the `space` method to actually print a space. Besides, it's technically a space generator.
It adds breakables next to delimiters, and gives more control to the caller. Will be useful in the next commits when we add more vocab.
stackmystack
force-pushed
the
rich-api
branch
from
20c8bcc to
60a44e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses many points in #55