string-functions: fix a subtle bug on [] calls of Table
#125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To reproduce it, open rails console, make a `t = Table::new("tab")`, then
try to t[:col]. StringFunctions' [] will be called with the wrong types.
No backtrace, no nothing.
If you want a backtrace, you can do `pp t[:col]`. It turns out that our
[] was shadowing Struct's own [] that is defined in C, not in Ruby,
and it explaians why it was impossible to get the `source_location`
from the call stack.
stackmystack
force-pushed
the
table-inspect-bug
branch
from
a0d26cd to
b1e256a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reproduce it, open rails console, make a
t = Table::new("tab"), then try to t[:col]. StringFunctions' [] will be called with the wrong types. No backtrace, no nothing.If you want a backtrace, you can do
pp t[:col]. It turns out that our [] was shadowing Struct's own [] that is defined in C, not in Ruby, and it explaians why it was impossible to get thesource_locationfrom the call stack.