Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) Try to make JaCoCo work with JDK 17; odd failure still #4971

Closed
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -210,15 +210,30 @@
<groupId>org.apache.maven.plugins</groupId>
<version>${version.plugin.surefire}</version>
<artifactId>maven-surefire-plugin</artifactId>
<!-- 13-Feb-2025, tatu: Try to make JaCoCo work -->
<dependencies>
<dependency>
<groupId>org.junit.platform</groupId>
<artifactId>junit-platform-surefire-provider</artifactId>
<version>1.3.2</version>
</dependency>
</dependencies>
<configuration>
<!-- Needed by some of the tests -->
<argLine>--add-opens=java.base/java.util=tools.jackson.databind
</argLine>
<!-- 13-Feb-2025, tatu: Try to make JaCoCo work -->
<forkCount>1</forkCount> <!-- Use single JVM -->
<reuseForks>true</reuseForks>

<!-- 26-Nov-2019, tatu: moar parallelism! Per-class basis, safe, efficient enough
... although not 100% sure this makes much difference TBH
-->
<threadCount>4</threadCount>
<!-- 13-Feb-2025, tatu: Seems to make no difference, remove -->
<!--
<threadCount>1</threadCount>
<parallel>classes</parallel>
-->
</configuration>
</plugin>

Expand All @@ -238,13 +253,17 @@
<artifactId>jacoco-maven-plugin</artifactId>
<executions>
<execution>
<id>prepare-agent</id>
<goals>
<goal>prepare-agent</goal>
</goals>
</execution>
<execution>
<id>report</id>
<phase>test</phase>
<!-- 13-Feb-2025, tatu: was "test" in 2.x but for some reason JDK 17
needs this
-->
<phase>verify</phase>
<goals>
<goal>report</goal>
</goals>
Expand Down
Loading