Test refactoring: use "@JacksonTestFailureExpected" from jackson-core test-jar

[cowtowncoder]

So: convert existing "tofix" tests to use shared version of annotations.

[cowtowncoder]

cc @JooHyukKim : second part of refactoring, to use shared definitions. Should be possible to do for other repos too. What is needed:

• Add dependency in pom.xml:

    <dependency>
      <groupId>tools.jackson.core</groupId>
      <artifactId>jackson-core</artifactId>
      <version>${jackson.version.core}</version>
      <classifier>tests</classifier>
      <type>test-jar</type>
      <scope>test</scope>
    </dependency>

• No need to add module dependency (yet) -- for some reason module metadata not included

But with that should be able to use:

• tools.jackson.core.testutil.JacksonTestUtilBase as base class (or via static includes) -- like DatabindTestUtil does
• tools.jackson.core.testutil.failure.JacksonTestFailureExpected annotation

to replace current in-project copies of functionality.

[cowtowncoder]

cc @JooHyukKim : second part of refactoring, to use shared definitions. Should be possible to do for other repos too. What is needed:

• Add dependency in pom.xml:

    <dependency>
      <groupId>tools.jackson.core</groupId>
      <artifactId>jackson-core</artifactId>
      <version>${jackson.version.core}</version>
      <classifier>tests</classifier>
      <type>test-jar</type>
      <scope>test</scope>
    </dependency>

• No need to add module dependency (yet) -- for some reason module metadata not included

But with that should be able to use:

• tools.jackson.core.testutil.JacksonTestUtilBase as base class (or via static includes) -- like DatabindTestUtil does
• tools.jackson.core.testutil.failure.JacksonTestFailureExpected annotation

to replace current in-project copies of functionality.

[JooHyukKim]

Okay.. 1. add jackson-core dependency and 2.do the migration.
Should we be applying to master branch only? @cowtowncoder

[cowtowncoder]

@JooHyukKim I already did this for jackson-databind here. But unfortunately my second attempt, with XML module:

FasterXML/jackson-dataformat-xml#707

does not seem to work, so I am not sure if we can make things work... so let's keep this on hold for now.

[JooHyukKim]

does not seem to work, so I am not sure if we can make things work... so let's keep this on hold for now.

Yeah... awe are almost done with migration so this can wait 👌🏽

This task may end up taking so much resources cause we can't really test light weight.

I was thinking maybe PJ could help(intentionally not tagging) but holding off for now seems reasonable

[cowtowncoder]

@JooHyukKim right. I think it has something to do with Maven not being able to get qualifier dependency right (logical artifact id is jackson-core for both jars).
Or it could be due to test-jar missing module-info.class (cannot get it included no matter what.

One possibility would be to actually create repo like jackson-test-base and publish actual stand-alone jar. Need to think about this a bit.
(theoretically could alternatively make jackson-core multi-project Maven thing but... I don't like that idea).