Merge pull request #39 from reactiveops/sudermanjr/fix-38

Sudermanjr/fix 38
FairwindsOps · Jan 8, 2019 · bbbe411 · bbbe411
2 parents 0e0d91c + 1bdd1ed
commit bbbe411
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 9 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,10 +4,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
-## Unreleased
+## [0.10.2]
 
 ### Fixed
 - fixing error were value-strings from the course where not being set as set-string on the command line
+- improved output when a desired environment variable is not set
+- no longer adding the helm_args from course.yml twice
 
 ## [0.10.1]
 

diff --git a/reckoner/chart.py b/reckoner/chart.py
@@ -209,7 +209,6 @@ def install(self, namespace=None, context=None):
         if self.context is not None:
             self.args.append('--kube-context={}'.format(self.context))
         self.args.extend(self.debug_args)
-        self.args.extend(self.helm_args)
         if self.version:
             self.args.append('--version={}'.format(self.version))
         for file in self.files:

diff --git a/reckoner/meta.py b/reckoner/meta.py
@@ -14,5 +14,5 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-__version__ = '0.10.1'
+__version__ = '0.10.2'
 __author__ = 'ReactiveOps, Inc.'
diff --git a/tests/test_reckoner.py b/tests/test_reckoner.py
@@ -361,7 +361,6 @@ def test_chart_install(self):
                     #'--namespace={}'.format(chart.namespace),
                     chart.release_name,
                     chart.chart_path,
-
                 ]
             )
             if chart.name == test_environ_var_chart:
@@ -376,7 +375,6 @@ def test_chart_install(self):
                         chart.release_name,
                         chart.chart_path,
                         '--namespace={}'.format(chart.namespace),
-                        '--recreate-pods',
                         '--set={}={}'.format(test_environ_var_name, test_environ_var)]
                 )
             if chart.release_name == test_values_strings_chart:
@@ -390,15 +388,11 @@ def test_chart_install(self):
                         chart.release_name,
                         chart.chart_path,
                         '--namespace={}'.format(chart.namespace),
-                        '--recreate-pods',
                         '--version=0.1.0',
                         '--set-string=string=string',
                         '--set-string=integer=10',
                         '--set-string=boolean=True'
                     ]
-
-
-
                 )