Fix: rolebindingRolePodExecAttach check #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the case of a RoleBinding that points to a ClusterRole. In that case, we ignore the RoleBinding since it will be evaluated by the rolebindingClusterRolePodExecAttach check.
greg5813
requested review from
sudermanjr,
jdesouza and
vitorvezani
as code owners
|
Thanks for your contribution Greg, I've added a test to avoid regressions in the future |
YuMuuu
pushed a commit
to YuMuuu/polaris
that referenced
this pull request
Oct 3, 2024
* Fix: rolebindingRolePodExecAttach check Fix the case of a RoleBinding that points to a ClusterRole. In that case, we ignore the RoleBinding since it will be evaluated by the rolebindingClusterRolePodExecAttach check. * add tests for role-binding that uses a cluster-role binding --------- Co-authored-by: Vitor Vezani <vitor.vezani@fairwinds.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the case of a RoleBinding that points to a ClusterRole.
In that case, we ignore the RoleBinding validation altogether since it will be evaluated by the rolebindingClusterRolePodExecAttach check.
This PR fixes the rolebindingRolePodExecAttach check
Checklist
Description
What's the goal of this PR?
Fix the check of a RoleBinding that references a Role allowing pods/exec or pods/attach in the case that it points to a ClusterRole.
What changes did you make?
Modify the kind field value of the roleRef field of the RoleBinding from "Role" to "ClusterRole" in the schemaString
What alternative solution should we consider, if any?
NA