Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'important' section on Updating Fabric #192

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Conversation

woseK
Copy link
Contributor

@woseK woseK commented Oct 13, 2024

The IMPORTANT section of the Updating Fabric page wasn't working before, so I fixed it by using the "GitHub-flavored Alerts".

Before:
image

After:
image

@woseK woseK requested a review from a team as a code owner October 13, 2024 20:26
Copy link

netlify bot commented Oct 13, 2024

Deploy Preview for nimble-elf-d9d491 ready!

Name Link
🔨 Latest commit e089f83
🔍 Latest deploy log https://app.netlify.com/sites/nimble-elf-d9d491/deploys/670d0c2103a1fa0008e49295
😎 Deploy Preview https://deploy-preview-192--nimble-elf-d9d491.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@its-miroma its-miroma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

However, we prefer to use Vitepress Custom Containers for consistency, and because it aids with translation.

Thank you!

Co-authored-by: Miroma <136986257+its-miroma@users.noreply.github.com>
@woseK woseK requested a review from its-miroma October 14, 2024 12:22
@its-miroma its-miroma added stage:ready This is ready to be merged correction Something isn't right on a page labels Oct 14, 2024
@its-miroma its-miroma merged commit cb6a1c4 into FabricMC:main Oct 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
correction Something isn't right on a page stage:ready This is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants