Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Item pages #116

Merged
merged 32 commits into from
Jul 1, 2024
Merged

Item pages #116

merged 32 commits into from
Jul 1, 2024

Conversation

IMB11
Copy link
Member

@IMB11 IMB11 commented Jun 14, 2024 •
edited
Loading

  • "Creating Your First Item"
    • Change Screenshot
    • Crafting Recipes
    • Stack Size
    • Compostable/Fuel
  • "Food Items"
  • "Armor"
    • Knockback Resistance stuff
  • "Tools"
  • "Custom Items"
    • Tooltips
  • "Custom Item Groups"
  • Text And Translations (along for the ride)

Also implemented:

  • asset downloading components, self explanatory, allows users to download example textures etc.
  • medium-zoom, allows users to zoom in images within the page, useful for pages with IDE screenshots and just in general for accessiblity.
  • VidStack based videoplayer, will be useful for guides with webm videos, no more need to use audioless webp animations to show something in-game. It automatically has support for Youtube Embeds as well which will prove useful for "Using the ide" Page [Part 1] #111 and future PRs with external videos.

@netlify Netlify
Copy link

netlify bot commented Jun 14, 2024 •
edited
Loading

✅ Deploy Preview for nimble-elf-d9d491 ready!

Name Link
🔨 Latest commit bd0d67b
🔍 Latest deploy log https://app.netlify.com/sites/nimble-elf-d9d491/deploys/6671f9a1cd50250008be7211
😎 Deploy Preview https://deploy-preview-116--nimble-elf-d9d491.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@IMB11 IMB11 mentioned this pull request Jun 14, 2024
Closed
@IMB11 IMB11 added new-content A new page or set of pages stage:expansion This should be expanded labels Jun 14, 2024
@IMB11 IMB11 marked this pull request as ready for review June 14, 2024 23:11
@IMB11 IMB11 requested review from a team as code owners June 14, 2024 23:11
@IMB11 IMB11 changed the title Items pages. Item pages Jun 14, 2024
JR1811
JR1811 reviewed Jun 14, 2024
View reviewed changes
develop/items/first-item.md Outdated Show resolved Hide resolved
JR1811
JR1811 reviewed Jun 15, 2024
View reviewed changes
develop/items/custom-armor.md Show resolved Hide resolved
develop/items/custom-tools.md Outdated Show resolved Hide resolved
@IMB11 IMB11 mentioned this pull request Jun 15, 2024
Closed
@IMB11 IMB11 added stage:cleanup This should be cleaned up and removed stage:expansion This should be expanded labels Jun 15, 2024
@IMB11
Copy link
Member Author

IMB11 commented Jun 15, 2024

This is ready for review.

@IMB11 IMB11 added this to the MVP milestone Jun 15, 2024
@IMB11 IMB11 requested a review from JR1811 June 15, 2024 12:11
modmuss50
modmuss50 reviewed Jun 15, 2024
View reviewed changes
Copy link
Member

@modmuss50 modmuss50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a great start, just a few comments.

reference/latest/src/main/java/com/example/docs/item/ModItems.java Outdated Show resolved Hide resolved
reference/latest/src/main/java/com/example/docs/item/ModItems.java Outdated Show resolved Hide resolved
reference/latest/src/main/java/com/example/docs/item/ModItems.java Outdated Show resolved Hide resolved
reference/latest/src/main/java/com/example/docs/item/FabricDocsReferenceItems.java Outdated Show resolved Hide resolved
reference/latest/src/main/java/com/example/docs/item/FabricDocsReferenceItems.java Show resolved Hide resolved
develop/items/first-item.md Outdated Show resolved Hide resolved
develop/items/first-item.md Show resolved Hide resolved
develop/items/first-item.md Show resolved Hide resolved
develop/items/first-item.md Show resolved Hide resolved
develop/items/food.md Show resolved Hide resolved
@IMB11 IMB11 requested a review from modmuss50 June 18, 2024 21:21
@IMB11
Copy link
Member Author

IMB11 commented Jun 18, 2024

This is pretty much done, anyone is welcome to review/give feedback on areas that might need improving.

This was referenced Jun 19, 2024
Closed
Merged
Closed
@IMB11 IMB11 added stage:ready This is ready to be merged and removed stage:cleanup This should be cleaned up labels Jul 1, 2024
@IMB11 IMB11 merged commit 2a19835 into FabricMC:main Jul 1, 2024
7 checks passed
@IMB11 IMB11 deleted the items branch July 1, 2024 10:23
JR1811 pushed a commit to JR1811/fabric-docs that referenced this pull request Jul 17, 2024
@IMB11
Item pages (FabricMC#116)
3a01822
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@modmuss50 modmuss50 modmuss50 approved these changes

@JR1811 JR1811 Awaiting requested review from JR1811

Assignees
No one assigned
Labels
new-content A new page or set of pages stage:ready This is ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing image focus on click Developer Guides: Adding items
3 participants
@IMB11 @modmuss50 @JR1811