Added variable parameters #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have not had time to look deeply into this but I'd like to step back and understand what made you make this change. It seems a serious limitation of the tool. Changing 3rd party tools is really a last resort type of thing since you basically inherit the burden of supporting it internally in perpetuity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated business_rules engine to allow for parameters defined in the JSON rule file and passed to the variable functions.
This allows for variable queries with multiple co-dependent data, e.g. clinvar is matches_allele and matches_allele is pathogenic. Otherwise variables are evaluated independent of each other and only one result can be evaluated.
Tested with existing and a new unit test (test_rules.py). Tested and backwards compatible with existing ACMG rule engine.