Skip to content

Commit

Permalink
fix: lint
Browse files Browse the repository at this point in the history
fix: codemeta release ci
fix: test
  • Loading branch information
xgui3783 committed Oct 3, 2024
1 parent 39679ca commit 0ec5f9e
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 5 deletions.
1 change: 1 addition & 0 deletions .github/workflows/release-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,4 +70,5 @@ jobs:
RELEASE_NOTES=$(< docs/releases/v${VERSION_NUM}.md)
CODEMETA_RELEASE_NOTES=$(jq -r '.["schema:releaseNotes"]' codemeta.json)
# use awk '{printf "%s\\n", $0}' docs/releases/v{VERSION}.md to fix
test "$RELEASE_NOTES" == "$CODEMETA_RELEASE_NOTES" && echo "Release notes matches" || exit 1
2 changes: 1 addition & 1 deletion codemeta.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"python 3",
"typescript"
],
"schema:releaseNotes": "# v2.14.10\n\n## Bugfix\n\n- Fix deployment scripts\n- Fix region update to updated siibra-api endpoint\n\n## Behind the scenes\n\n- Re-enable siibra-api warning mismatch warning\n- Adapt to siibra-api v0.3.18 point assignment rhetoric\n- Enable cheat code, removing obsolete experimental flags\n- If `HOST_PATHNAME` env is provided, also listens on root path\n- Added servicemeta endpoint\n\n## Known regressions\n\n- Labelled assignment now takes a little longer. Additionally, the assigned value does not match that of the index label. This will be addressed in a future update. (The temporary regression allows for significant performant statistical assignment, as well more accurate label assignment.)\n",
"schema:releaseNotes": "# v2.14.11\n\n## Feature\n\n- (experimental) showing coordinates of all warped spaces\n\n## Bugfix\n\n- Fixed inconsistent saneurl creation (Thanks to Sebastian Bludau for reporting this)\n",
"runtimePlatform": "docker",
"version": "2.14.11",
"contIntegration": "https://github.com/FZJ-INM1-BDA/siibra-explorer/actions",
Expand Down
1 change: 0 additions & 1 deletion docs/releases/v2.14.11.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,3 @@
## Bugfix

- Fixed inconsistent saneurl creation (Thanks to Sebastian Bludau for reporting this)

2 changes: 1 addition & 1 deletion src/share/saneUrl/saneUrl.service.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { HttpClient } from "@angular/common/http";
import { Injectable } from "@angular/core";
import { combineLatest, throwError } from "rxjs";
import { throwError } from "rxjs";
import { catchError, mapTo, switchMap, take } from "rxjs/operators";
import { IKeyValStore, NotFoundError } from '../type'
import { environment } from "src/environments/environment";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import { atlasSelection } from "src/state"
import { SxplrTemplate } from "src/atlasComponents/sapi/sxplrTypes"
import { NEHUBA_INSTANCE_INJTKN } from "../util"
import { MediaQueryDirective } from "src/util/directives/mediaQuery.directive"
import { InterSpaceCoordXformSvc } from "src/atlasComponents/sapi/core/space/interSpaceCoordXform.service"

const mockNehubaConfig = {
dataset: {
Expand Down Expand Up @@ -86,6 +87,13 @@ describe('> statusCard.component.ts', () => {
{
provide: NEHUBA_INSTANCE_INJTKN,
useValue: NEVER
},
{
provide: InterSpaceCoordXformSvc,
useValue: {
TmplIdToValidSpaceName() {throw new Error()},
transform(){ throw new Error() }
}
}
]
}).compileComponents()
Expand Down
4 changes: 2 additions & 2 deletions src/viewerModule/nehuba/statusCard/statusCard.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import {
import { select, Store } from "@ngrx/store";
import { LoggingService } from "src/logging";
import { NehubaViewerUnit } from "../nehubaViewer/nehubaViewer.component";
import { Observable, Subject, combineLatest, concat, forkJoin, merge, of } from "rxjs";
import { Observable, Subject, combineLatest, concat, merge, of } from "rxjs";
import { map, filter, takeUntil, switchMap, shareReplay, debounceTime, scan } from "rxjs/operators";
import { Clipboard, MatBottomSheet, MatSnackBar } from "src/sharedModules/angularMaterial.exports"
import { ARIA_LABELS, QUICKTOUR_DESC } from 'common/constants'
Expand Down Expand Up @@ -174,7 +174,7 @@ export class StatusCardComponent {
of(startingValues),
merge(
...wrapTmplNames.map(
({ srcTmplName, targetTmplName, targetTmplId }) => this.xformSvc.transform(srcTmplName, targetTmplName, position.map(v => v * 1e6) as [number, number, number]).pipe(
({ srcTmplName, targetTmplName }) => this.xformSvc.transform(srcTmplName, targetTmplName, position.map(v => v * 1e6) as [number, number, number]).pipe(
map(result => {
return {
[targetTmplName]: result
Expand Down

0 comments on commit 0ec5f9e

Please sign in to comment.