Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added LICENSE. Still need to add the license to each file. #103

Merged
merged 80 commits into from
Mar 7, 2024

Conversation

AlArgente
Copy link
Contributor

Queda añadir la licencia a los archivos. En cuanto Paco responda al correo, se añade a todos los archivos.

@AlArgente AlArgente requested a review from xehartnort July 6, 2023 08:06
@AlArgente AlArgente self-assigned this Jul 6, 2023
@xehartnort xehartnort added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 6, 2023
@github-actions
Copy link

github-actions bot commented Jul 6, 2023

Coverage

Coverage Report
FileStmtsMissCoverMissing
flex/common
   utils.py751580%135–151, 189
flex/data
   dataset.py1542981%53–59, 130, 200, 202, 214, 222–238, 288–289, 306–307, 314, 322, 327, 334–335, 397, 413–414
   fed_data_distribution.py182199%397
   lazy_indexable.py79297%55, 89
   pluggable_datasets.py62198%27
flex/datasets
   federated_datasets.py452642%35, 39–71, 75–89, 102
   flexible_datasets.py11373%29, 46–47
flex/pool
   aggregators.py50492%55–56, 145–146
   primitives_pt.py635021%46, 61–63, 104–122, 158–170, 197–206, 235–244
   primitives_tf.py42783%74–84
TOTAL127013889% 

Tests Skipped Failures Errors Time
188 4 💤 0 ❌ 0 🔥 2m 56s ⏱️

@AlArgente
Copy link
Contributor Author

If I'm not wrong, the PR is ready to go! License applied to all .py files!

AlArgente and others added 28 commits March 7, 2024 12:48
…w in FlexPool we only talk about pools, and use the work architecture outside.
…th_huggingface_dataset to match the from_huggingface_dataset from flex.data.Dataset. Now we can support to load datasets that might not have a label column specified. Also, modified the function that load a huggingface dataset, as the test was failing when downloading a dataset with a subset specified due to an upgrade in the 'datasets' package. The test that was failing was ´test_from_huggingface_text_dataset_lazy_str_and_subset´ from the test_fed_data_distribution file. I proved the code from the official site https://huggingface.co/datasets/tweet_eval\?library\=true and it was giving error, and I searched the error and added the ´ignore_verifications=True option that found in https://discuss.huggingface.co/t/nonmatchingsplitssizeserror/30033. The ´load_dataset´ is giving error when loading a subset from a dataset, because you have to specify the subset, but even when you specify the subset it gives you all the available subsets and not the specified.
… the rull.toml, so it does not give errors when runing the linter.
@AlArgente
Copy link
Contributor Author

Merging with the LICENSE added.

@AlArgente AlArgente merged commit 024171f into main Mar 7, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants