De-static IceAdapter class #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GodFuper
reviewed
Nov 28, 2024
| @@ -99,10 +99,10 @@ public void initStaticVariables() { | |||
|
|
|||
| runOnUIThread(() -> { | |||
| controller.versionLabel.setText("Version: %s".formatted(IceAdapter.VERSION)); | |||
There was a problem hiding this comment.
why not IceAdapter.getVersion()
There was a problem hiding this comment.
Because I ported the old commit and things have changed since then 😛 Will fix
GodFuper
reviewed
Nov 28, 2024
| public static void init() { | ||
| log.info("Creating RPC server on port {}", IceAdapter.RPC_PORT); | ||
| public static void init(int port) { | ||
| Debug.RPC_PORT = port; |
There was a problem hiding this comment.
Why RPC_PORT not in RPCService?
GodFuper
reviewed
Nov 28, 2024
| loadOptions(iceOptions); | ||
| Debug.DELAY_UI_MS = iceOptions.getDelayUi(); | ||
| Debug.ENABLE_DEBUG_WINDOW = iceOptions.isDebugWindow(); | ||
| Debug.ENABLE_INFO_WINDOW = iceOptions.isInfoWindow(); |
There was a problem hiding this comment.
Why do we create a new static variable if we have it in IceOptions?
There was a problem hiding this comment.
Will come in a later commit ;) One thing at a time.
Prepare a slow transition from static-everything to dependency injection
Brutus5000
force-pushed
the
feature/destatic-iceadapter-class
branch
from
a509f31 to
a0aa9ca
Compare
|
@GodFuper Okay I made all static variables of IceAdapter class private now, with restricted access via (still static) getters. If you look into the original PR, I try to go one class at a time, so the review scope is smaller and I don't intentionally introduce different behavior. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare a slow transition from static-everything to dependency injection
Stripped out of #38