Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update python-publish workflow #3797

Merged
merged 1 commit into from
Feb 12, 2025
Merged

build: update python-publish workflow #3797

merged 1 commit into from
Feb 12, 2025

Conversation

ccmao1130
Copy link
Contributor

"Slack notification on failure" keeps failing due to Slack API updates

@ccmao1130 ccmao1130 reopened this Feb 12, 2025
@ccmao1130
Copy link
Contributor Author

ccmao1130 commented Feb 12, 2025

@desmondcheongzx We updated something similar for the broken link checker, can you double check if this is set up correctly? Do we need:

    runs-on: self-hosted
    if: failure()
    needs: ...

Copy link

codspeed-hq bot commented Feb 12, 2025

CodSpeed Performance Report

Merging #3797 will degrade performances by 46.46%

Comparing workflow-publish (fc72980) with main (ca36593)

Summary

❌ 3 regressions
✅ 24 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_count[1 Small File] 3.2 ms 4.1 ms -21.16%
test_iter_rows_first_row[100 Small Files] 167 ms 311.9 ms -46.46%
test_show[100 Small Files] 16.1 ms 23.6 ms -31.95%

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.82%. Comparing base (ca36593) to head (fc72980).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3797      +/-   ##
==========================================
- Coverage   77.82%   77.82%   -0.01%     
==========================================
  Files         745      745              
  Lines       94416    94414       -2     
==========================================
- Hits        73480    73475       -5     
- Misses      20936    20939       +3     

see 3 files with indirect coverage changes

Copy link
Contributor

@desmondcheongzx desmondcheongzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@ccmao1130 ccmao1130 merged commit 147e11a into main Feb 12, 2025
78 of 80 checks passed
@ccmao1130 ccmao1130 deleted the workflow-publish branch February 12, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants