-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Implement null-safe equality operator #3663
Conversation
CodSpeed Performance ReportMerging #3663 will degrade performances by 40.33%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3663 +/- ##
==========================================
- Coverage 78.06% 77.76% -0.31%
==========================================
Files 728 728
Lines 89967 90346 +379
==========================================
+ Hits 70236 70259 +23
- Misses 19731 20087 +356
|
The test coverage is low bc I'm not able to test FixedSizeBinary properly (see src/daft-core/src/array/ops/comparison.rs:2117, that print statement is never hit). Also, I am not able to test
clauses are also not tested but this issue persists for regular equality so I have not seriously tried fixing it yet. All current tests are successful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good to me! Some comments
Co-authored-by: Desmond Cheong <desmondcheongzx@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for implementing this!
Adds support for null-safe equality comparisons (
<=>
) in Daft, similar to MySQL's implementation. This operator treats NULL values specially:Includes comprehensive test coverage for both expression-based and SQL-based usage.