Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix incorrect deployer.zkWallet usage #8

Merged
merged 1 commit into from
Jan 28, 2025
Merged

fix: Fix incorrect deployer.zkWallet usage #8

merged 1 commit into from
Jan 28, 2025

Conversation

famouswizard
Copy link
Contributor

I noticed that deployer.zkWallet was being used incorrectly, as deployer itself already contains the zkWallet passed during its initialization. The hre.zkUpgrades.deployProxy method expects the deployer object, not the wallet directly. This has been corrected to ensure proper functionality.

@famouswizard famouswizard requested a review from boyuanx as a code owner January 28, 2025 19:22
@boyuanx
Copy link
Collaborator

boyuanx commented Jan 28, 2025

Thanks for the catch!

@boyuanx boyuanx merged commit e07c45c into EthSign:main Jan 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boyuanx boyuanx boyuanx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@famouswizard @boyuanx