Sometime, GeolocationHint can be an array and not directly a string - fix for php8 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prigaux
reviewed
Sep 5, 2024
templates.php
Outdated
| @@ -321,6 +321,11 @@ function printOptionElement($IDProviders, $key, $selectedIDP){ | |||
| } | |||
|
|
|||
| function geoDataAttributes($GeolocationHint) { | |||
| // Sometime, $GeolocationHint cans be an array and not directly a string | |||
| if(is_array($GeolocationHint)) { | |||
| echo $GeolocationHint; | |||
vbonamy
force-pushed
the
fix-geolocation-array-php8
branch
from
cab699c to
ee14fc2
Compare
prigaux
reviewed
Sep 5, 2024
templates.php
Outdated
| @@ -321,6 +321,10 @@ function printOptionElement($IDProviders, $key, $selectedIDP){ | |||
| } | |||
|
|
|||
| function geoDataAttributes($GeolocationHint) { | |||
| // Sometime, $GeolocationHint cans be an array and not directly a string | |||
| if(is_array($GeolocationHint)) { | |||
| $GeolocationHint = array_pop(array_reverse($GeolocationHint)); | |||
There was a problem hiding this comment.
Y'a une raison de ne pas faire simplement :
$GeolocationHint = $GeolocationHint[0];
?
vbonamy
force-pushed
the
fix-geolocation-array-php8
branch
from
ee14fc2 to
5a96356
Compare
|
Après ces 2 push force je confirme que c'est toujours ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Après un passage en php8, notre esup-wayf ne remontait plus d'établissements pour les SP proposés à EduGain.
Il se trouve que dans les SPs EduGain certains ont un GeolocationHint qui remonte en tant que tableau (à un élément) et pas directemet une chaine de caractères.
La fonction preg_match devait s'en accommoder en php7, ce n'est plus le cas en php8.
Ce PR permet de contourrner ce problème