Generate offline map with custom parameters #314

TADraeseke · 2025-02-01T00:40:22Z

Description

PR to add a new Kotlin sample Generate offline map with custom parameters in Edit and manage data category.

…eters

shubham7109

Nice sample @TADraeseke, I have a few code suggesstion changes which would be helpful to have. Hope my comments here makes sense, or I could share my thoughts in detail if you would prefer:

In summary:

Update the sample to use the provision path location to save offline map
Simplify the use of multiple ?.let/as? Kotlin checks
Pass in targetFeatureLayer rather than layerName causing repeated lookups.
UI feedback to break up options to sections

samples/generate-offline-map-with-custom-parameters/src/main/AndroidManifest.xml

...offlinemapwithcustomparameters/components/GenerateOfflineMapWithCustomParametersViewModel.kt

...nerateofflinemapwithcustomparameters/screens/GenerateOfflineMapWithCustomParametersScreen.kt

shubham7109 · 2025-02-04T22:59:25Z

...nerateofflinemapwithcustomparameters/screens/GenerateOfflineMapWithCustomParametersScreen.kt

+}
+
+@Composable
+fun OverrideParameters(


Subjective compose high-level feedback:

Could each of the 4 sliders use fillMaxWidth with a consistent horizontal padding (for nav gestures) but also it's relevant labels along with the values are represented above each slider. This would help ensure each slider looks to be the same "width" for UI consistency.

This sample looks to have 4 general selections of options, "Adjust basemap", "Include layers", "Filter feature layer" and "Crop layers to extent". Could each of these 4 sections be added into a container (eg Card) to help break up the UI? Or even something as simple as a horizontal divider with spacing should also do the trick!

I've not done the consistent sliders yet, but have used horizontal dividers. The cards looked a bit funny without loads of internal padding on all child components. So I just went with the less code heavy solution.

Thanks for considering it, the card suggestion came mainly from looking at swift. The dividers look great and noticeably help break up the UI.

TADraeseke · 2025-02-05T02:32:20Z

Thank you @shubham7109 -- I've made tons of changes now. In addition to your feedback I've:

disabled map rotation
blocked taps while the progress dialog is showing
Handle a reset option once map is generated
Loads of other refactoring

The only one I haven't done is remove sliders from rows. I'm just concerned it'll add alot of extra UI code, but maybe a quick call can sort it out.

Anyways ready for re-review. Thanks!

shubham7109

Thanks @TADraeseke! The changes looks great and the reset functionality works well. I had some minor feedback suggestions mainly to do with formatting, and code quality.

Happy to approve 👍

shubham7109 · 2025-02-05T20:38:43Z

samples/generate-offline-map-with-custom-parameters/README.md

+    * Set the level IDs you want to download with `exportTileCacheParameters.levelIds.add(...)`.
+    * To buffer the extent, use `exportTileCacheParameters.areaOfInterest` where bufferedGeometry can be calculated with the `GeometryEngine`.
+6. To remove operational layers from the download:
+    * Create a `OfflineParametersKey` with the operational layer.


Suggested change

* Create a `OfflineParametersKey` with the operational layer.

* Create an `OfflineParametersKey` with the operational layer.

shubham7109 · 2025-02-05T20:39:29Z

samples/generate-offline-map-with-custom-parameters/README.md

+6. To remove operational layers from the download:
+    * Create a `OfflineParametersKey` with the operational layer.
+    * Get the generate geodatabase layer options using the key with `parameterOverrides.generateGeodatabaseParameters[key].layerOptions`
+    * Using the `GenerateLayerOption` list, and remove the layer if its the layer option's ID matches the layer's ID.


Suggested change

* Using the `GenerateLayerOption` list, and remove the layer if its the layer option's ID matches the layer's ID.

* Use the `GenerateLayerOption` list to remove the layer if the layer option's ID matches the layer's ID.

shubham7109 · 2025-02-05T20:40:04Z

...offlinemapwithcustomparameters/components/GenerateOfflineMapWithCustomParametersViewModel.kt

+import kotlinx.coroutines.launch
+import java.io.File
+
+


Suggested change

shubham7109 · 2025-02-05T20:40:44Z

...offlinemapwithcustomparameters/components/GenerateOfflineMapWithCustomParametersViewModel.kt

+     * Sets up a portal item and displays map area to take offline
+     */
+    private fun setUpMap() {
+


Suggested change

shubham7109 · 2025-02-05T20:40:52Z

...offlinemapwithcustomparameters/components/GenerateOfflineMapWithCustomParametersViewModel.kt

+                messageDialogVM.showMessageDialog(
+                    title = it.message.toString()
+                )
+


Suggested change

shubham7109 · 2025-02-05T20:56:50Z

...nerateofflinemapwithcustomparameters/screens/GenerateOfflineMapWithCustomParametersScreen.kt

+                if (mapViewModel.showResetButton) {
+                    Button(
+                        onClick = {
+                            mapViewModel.reset()
+                        }, modifier = Modifier.align(Alignment.CenterHorizontally)
+                    ) {


Suggested change

if (mapViewModel.showResetButton) {

Button(

onClick = {

mapViewModel.reset()

}, modifier = Modifier.align(Alignment.CenterHorizontally)

) {

if (mapViewModel.showResetButton) {

Button(

onClick = mapViewModel::reset,

modifier = Modifier.align(Alignment.CenterHorizontally)

) {

shubham7109 · 2025-02-05T20:59:48Z

...nerateofflinemapwithcustomparameters/screens/GenerateOfflineMapWithCustomParametersScreen.kt

+}
+
+@Composable
+fun OverrideParameters(


Thanks for considering it, the card suggestion came mainly from looking at swift. The dividers look great and noticeably help break up the UI.

shubham7109 · 2025-02-05T21:00:29Z

...nerateofflinemapwithcustomparameters/screens/GenerateOfflineMapWithCustomParametersScreen.kt

+                FloatingActionButton(modifier = Modifier.padding(bottom = 36.dp, end = 12.dp),
+                    onClick = { showBottomSheet = true }) {
+                    Icon(
+                        Icons.Filled.Settings, contentDescription = "Parameter overrides"
+                    )
+                }


Suggested change

FloatingActionButton(modifier = Modifier.padding(bottom = 36.dp, end = 12.dp),

onClick = { showBottomSheet = true }) {

Icon(

Icons.Filled.Settings, contentDescription = "Parameter overrides"

)

}

FloatingActionButton(

modifier = Modifier.padding(bottom = 36.dp, end = 12.dp),

onClick = { showBottomSheet = true }

) {

Icon(

imageVector = Icons.Filled.Settings,

contentDescription = "Parameter overrides"

)

}

shubham7109 · 2025-02-05T21:00:49Z

...nerateofflinemapwithcustomparameters/screens/GenerateOfflineMapWithCustomParametersScreen.kt

+    defineParameters: (Int, Int, Int, Boolean, Boolean, Int, Boolean) -> Unit,
+    setBottomSheetVisibility: (Boolean) -> Unit
+) {
+


Suggested change

shubham7109 · 2025-02-05T21:02:13Z

...nerateofflinemapwithcustomparameters/screens/GenerateOfflineMapWithCustomParametersScreen.kt

+        Text(
+            text = "Override parameters",
+            style = MaterialTheme.typography.titleMedium,
+            modifier = Modifier.align(Alignment.CenterHorizontally)
+        )
+
+            Text(text = "Adjust basemap", style = MaterialTheme.typography.labelLarge)
+            Row(


There seems to be an extra indentation here:

Suggested change

Text(

text = "Override parameters",

style = MaterialTheme.typography.titleMedium,

modifier = Modifier.align(Alignment.CenterHorizontally)

)

Text(text = "Adjust basemap", style = MaterialTheme.typography.labelLarge)

Row(

Text(

text = "Override parameters",

style = MaterialTheme.typography.titleMedium,

modifier = Modifier.align(Alignment.CenterHorizontally)

)

Text(text = "Adjust basemap", style = MaterialTheme.typography.labelLarge)

Row(

code and UI complete

7c1d22d

TADraeseke changed the base branch from main to v.next February 1, 2025 00:40

TADraeseke and others added 7 commits February 1, 2025 00:40

Merge branch 'v.next' into trev8939/generateOfflineMapWithCustomParam…

ff6acad

…eters

update README and metadata

704becc

pull from origin

49aedc3

pull from origin

c5ebe97

fix title in README

bd0e3e5

update screenshot

019131d

update metadata

0bc248e

TADraeseke added the New sample New Kotlin sample using ArcGIS Maps SDK label Feb 3, 2025

TADraeseke self-assigned this Feb 3, 2025

TADraeseke marked this pull request as ready for review February 3, 2025 19:28

TADraeseke added 2 commits February 3, 2025 16:50

basemap as layer not feature layer

fe04317

fix name

348494a

shubham7109 requested changes Feb 4, 2025

View reviewed changes

shubham7109 changed the title ~~Trev8939/generate offline map with custom parameters~~ Generate offline map with custom parameters Feb 5, 2025

TADraeseke added 2 commits February 4, 2025 16:09

disable map rotation, handle reset state and other PR fixes

5108b75

fix sliders and separate UI with dividers

f7266f8

TADraeseke requested a review from shubham7109 February 5, 2025 02:32

shubham7109 approved these changes Feb 5, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Generate offline map with custom parameters #314

Generate offline map with custom parameters #314

TADraeseke commented Feb 1, 2025

shubham7109 left a comment

shubham7109 Feb 4, 2025

TADraeseke Feb 5, 2025

shubham7109 Feb 5, 2025

TADraeseke commented Feb 5, 2025

shubham7109 left a comment

shubham7109 Feb 5, 2025

shubham7109 Feb 5, 2025

shubham7109 Feb 5, 2025

shubham7109 Feb 5, 2025

shubham7109 Feb 5, 2025

shubham7109 Feb 5, 2025

shubham7109 Feb 5, 2025

shubham7109 Feb 5, 2025

shubham7109 Feb 5, 2025

shubham7109 Feb 5, 2025

	* Create a `OfflineParametersKey` with the operational layer.
	* Create an `OfflineParametersKey` with the operational layer.

	* Using the `GenerateLayerOption` list, and remove the layer if its the layer option's ID matches the layer's ID.
	* Use the `GenerateLayerOption` list to remove the layer if the layer option's ID matches the layer's ID.

		import kotlinx.coroutines.launch
		import java.io.File

Generate offline map with custom parameters #314

Are you sure you want to change the base?

Generate offline map with custom parameters #314

Conversation

TADraeseke commented Feb 1, 2025

Description

shubham7109 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TADraeseke commented Feb 5, 2025

shubham7109 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment