-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trev8939/filter features in scene #312
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sample works well @TADraeseke, just a few feedback changes to make.
...om/esri/arcgismaps/sample/filterfeaturesinscene/components/FilterFeaturesInSceneViewModel.kt
Outdated
Show resolved
Hide resolved
...om/esri/arcgismaps/sample/filterfeaturesinscene/components/FilterFeaturesInSceneViewModel.kt
Outdated
Show resolved
Hide resolved
...om/esri/arcgismaps/sample/filterfeaturesinscene/components/FilterFeaturesInSceneViewModel.kt
Outdated
Show resolved
Hide resolved
...om/esri/arcgismaps/sample/filterfeaturesinscene/components/FilterFeaturesInSceneViewModel.kt
Outdated
Show resolved
Hide resolved
...om/esri/arcgismaps/sample/filterfeaturesinscene/components/FilterFeaturesInSceneViewModel.kt
Outdated
Show resolved
Hide resolved
...om/esri/arcgismaps/sample/filterfeaturesinscene/components/FilterFeaturesInSceneViewModel.kt
Outdated
Show resolved
Hide resolved
...java/com/esri/arcgismaps/sample/filterfeaturesinscene/screens/FilterFeaturesInSceneScreen.kt
Outdated
Show resolved
Hide resolved
Thanks @shubham7109 -- ready for re-review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sample looks good,
One suggestion
...java/com/esri/arcgismaps/sample/filterfeaturesinscene/screens/FilterFeaturesInSceneScreen.kt
Outdated
Show resolved
Hide resolved
...om/esri/arcgismaps/sample/filterfeaturesinscene/components/FilterFeaturesInSceneViewModel.kt
Outdated
Show resolved
Hide resolved
…maps/sample/filterfeaturesinscene/components/FilterFeaturesInSceneViewModel.kt Co-authored-by: Erick Lopez Solis <erick_solis@esri.com>
Thanks @eri9000! Made that change from button to FAB! |
Description
PR to add a new Kotlin sample Filter features in scene in Scenes category.