Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trev8939/filter features in scene #312

Merged
merged 9 commits into from
Feb 6, 2025
Merged

Conversation

TADraeseke
Copy link
Collaborator

Description

PR to add a new Kotlin sample Filter features in scene in Scenes category.

@TADraeseke TADraeseke marked this pull request as ready for review January 28, 2025 20:24
Copy link
Collaborator

@shubham7109 shubham7109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sample works well @TADraeseke, just a few feedback changes to make.

@TADraeseke
Copy link
Collaborator Author

Thanks @shubham7109 -- ready for re-review!

Copy link
Collaborator

@shubham7109 shubham7109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@eri9000 eri9000 assigned eri9000 and TADraeseke and unassigned eri9000 Feb 5, 2025
@eri9000 eri9000 self-requested a review February 5, 2025 18:19
Copy link
Collaborator

@eri9000 eri9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sample looks good,
One suggestion

TADraeseke and others added 2 commits February 6, 2025 22:34
…maps/sample/filterfeaturesinscene/components/FilterFeaturesInSceneViewModel.kt

Co-authored-by: Erick Lopez Solis <erick_solis@esri.com>
@TADraeseke TADraeseke requested a review from eri9000 February 6, 2025 22:47
@TADraeseke
Copy link
Collaborator Author

Thanks @eri9000! Made that change from button to FAB!

@TADraeseke TADraeseke merged commit e5e8550 into v.next Feb 6, 2025
1 check passed
@TADraeseke TADraeseke deleted the trev8939/filterFeaturesInScene branch February 6, 2025 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants