Create KML mutli track #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TADraeseke
requested changes
Jan 22, 2025
There was a problem hiding this comment.
I think it's a great sample @shubham7109! Really instructive and great code. Just suggestions below. Take or leave as you will!
...va/com/esri/arcgismaps/sample/createkmlmultitrack/components/CreateKMLMultiTrackViewModel.kt
Outdated
Show resolved
Hide resolved
...va/com/esri/arcgismaps/sample/createkmlmultitrack/components/CreateKMLMultiTrackViewModel.kt
Outdated
Show resolved
Hide resolved
...va/com/esri/arcgismaps/sample/createkmlmultitrack/components/CreateKMLMultiTrackViewModel.kt
Outdated
Show resolved
Hide resolved
...ain/java/com/esri/arcgismaps/sample/createkmlmultitrack/screens/CreateKMLMultiTrackScreen.kt
Outdated
Show resolved
Hide resolved
...ain/java/com/esri/arcgismaps/sample/createkmlmultitrack/screens/CreateKMLMultiTrackScreen.kt
Outdated
Show resolved
Hide resolved
|
@TADraeseke Thank you for the feedback. I added in the change requests, and ready for your review! |
TADraeseke
approved these changes
Jan 23, 2025
...ain/java/com/esri/arcgismaps/sample/createkmlmultitrack/screens/CreateKMLMultiTrackScreen.kt
Outdated
Show resolved
Hide resolved
...ain/java/com/esri/arcgismaps/sample/createkmlmultitrack/screens/CreateKMLMultiTrackScreen.kt
Outdated
Show resolved
Hide resolved
|
Thank you for the reviews and for helping with writing this sample design, @sorenoid @TADraeseke. Merging in the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR to add a new Kotlin sample "Create KML multi track" in
Edit and Manage Datacategory.Links and Data
Sample Issue: #5217