Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to Compose: Navigate route #275

Merged
merged 8 commits into from
Dec 9, 2024
Merged

Migrate to Compose: Navigate route #275

merged 8 commits into from
Dec 9, 2024

Conversation

shubham7109
Copy link
Collaborator

@shubham7109 shubham7109 commented Nov 19, 2024 •
edited
Loading

Description

PR to migrate the navigate route sample to Compose.

Links and Data

Issue: Link

What To Review

  • Review the code to make sure it is easy to follow like other samples on Android
  • README.md and README.metadata.json files

To Discuss:

  • I am unable to use setViewpointScale to "zoom in" when navigation starts which seems to be consumed by the viewpoint changes caused by setAutoPanMode. Is there a solution to make it so that the viewpoint scale zooms in to focus on navigation when the user starts navigation? If this seems unnecessary, I can remove the setViewpointScale functionality. (Solved)

@shubham7109 shubham7109 self-assigned this Nov 19, 2024
@shubham7109 shubham7109 changed the title migrated sample Migrate to Compose: Navigate route Nov 19, 2024
@shubham7109 shubham7109 added the enhancement New feature or request label Nov 19, 2024
@shubham7109 shubham7109 marked this pull request as ready for review November 19, 2024 19:12
TADraeseke
TADraeseke requested changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@TADraeseke TADraeseke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @shubham7109 -- big piece of work! Suggestions below

...-route/src/main/java/com/esri/arcgismaps/sample/navigateroute/screens/NavigateRouteScreen.kt Show resolved Hide resolved
.../src/main/java/com/esri/arcgismaps/sample/navigateroute/components/NavigateRouteViewModel.kt Outdated Show resolved Hide resolved
samples/navigate-route/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
...-route/src/main/java/com/esri/arcgismaps/sample/navigateroute/screens/NavigateRouteScreen.kt Outdated Show resolved Hide resolved
.../src/main/java/com/esri/arcgismaps/sample/navigateroute/components/NavigateRouteViewModel.kt Outdated Show resolved Hide resolved
.../src/main/java/com/esri/arcgismaps/sample/navigateroute/components/NavigateRouteViewModel.kt Show resolved Hide resolved
.../src/main/java/com/esri/arcgismaps/sample/navigateroute/components/NavigateRouteViewModel.kt Outdated Show resolved Hide resolved
.../src/main/java/com/esri/arcgismaps/sample/navigateroute/components/NavigateRouteViewModel.kt Outdated Show resolved Hide resolved
.../src/main/java/com/esri/arcgismaps/sample/navigateroute/components/NavigateRouteViewModel.kt Show resolved Hide resolved
.../src/main/java/com/esri/arcgismaps/sample/navigateroute/components/NavigateRouteViewModel.kt Outdated Show resolved Hide resolved
@shubham7109
Copy link
Collaborator Author

@TADraeseke I added this commit to help solve the scaling issue. Ready for your review.

@shubham7109
Copy link
Collaborator Author

@TADraeseke FYI, Swift uses the same reset logic: Link

TADraeseke
TADraeseke approved these changes Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@TADraeseke TADraeseke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Works great!

@puneet-pdx puneet-pdx self-requested a review December 6, 2024 20:16
puneet-pdx
puneet-pdx approved these changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@puneet-pdx puneet-pdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TADraeseke LGTM 👍🏽

@TADraeseke TADraeseke merged commit ab024d9 into v.next Dec 9, 2024
1 check passed
@TADraeseke TADraeseke deleted the shubham/migrate-navigate-route branch December 9, 2024 22:09
shubham7109 added a commit that referenced this pull request Jan 8, 2025
@shubham7109
Squashed commit of the following:
1d1219c 
commit a199a1d
Author: Shubham Sharma <shubhamsharma@esri.com>
Date:   Tue Jan 7 15:30:31 2025 -0800

    Remove CopyScreenshotsTask from Sample Viewer (#298)

commit 58774bf
Merge: e24e9ba 6ac1b9b
Author: Oliver Smith <67012037+01smito01@users.noreply.github.com>
Date:   Tue Jan 7 14:59:38 2025 +0000

    Migrate "Query features with Arcade expression" to Compose (#294)

commit 6ac1b9b
Author: Oliver Smith <osmith@esri.com>
Date:   Tue Jan 7 14:34:29 2025 +0000

    Changes after PR review

commit e24e9ba
Merge: 914c28f fae236f
Author: TADraeseke <tdraeseke@esri.com>
Date:   Tue Jan 7 00:07:41 2025 +0000

    Update sample to match contribution guidelines (#296)

commit 51f85cc
Author: Oliver Smith <osmith@esri.com>
Date:   Fri Jan 3 15:35:17 2025 +0000

    Make READY_TO_START explicit after map loaded

commit 914c28f
Merge: 80da229 4896afb
Author: TADraeseke <tdraeseke@esri.com>
Date:   Fri Dec 27 19:56:04 2024 +0000

    Animate images with image overlay (#293)

commit 4896afb
Merge: 9e6980e 023732d
Author: Trevor Draeseke <trev8939@esri.com>
Date:   Fri Dec 27 11:54:12 2024 -0800

    pull from origin

commit 9e6980e
Author: Trevor Draeseke <trev8939@esri.com>
Date:   Fri Dec 27 11:53:39 2024 -0800

    in line for each on image files

commit 023732d
Author: TADraeseke <tdraeseke@esri.com>
Date:   Thu Dec 26 23:59:05 2024 +0000

    Update AnimateImagesWithImageOverlayScreen.kt

commit be436d3
Author: Trevor Draeseke <trev8939@esri.com>
Date:   Thu Dec 26 15:51:47 2024 -0800

    use flow to track changes to fps, and UI improvements

commit fae236f
Author: Shubham Sharma <shubhamsharma@esri.com>
Date:   Mon Dec 23 14:34:54 2024 -0800

    change from Composable -> composable

commit 9690fcc
Author: Trevor Draeseke <trev8939@esri.com>
Date:   Mon Dec 23 13:14:56 2024 -0800

    comment clean up

commit 4551e3a
Author: Trevor Draeseke <trev8939@esri.com>
Date:   Mon Dec 23 13:10:50 2024 -0800

    comment clean up

commit 7ef6230
Author: Trevor Draeseke <trev8939@esri.com>
Date:   Mon Dec 23 12:57:04 2024 -0800

    PR fixes

commit 80da229
Author: Shubham Sharma <shubhamsharma@esri.com>
Date:   Mon Dec 23 10:43:25 2024 -0800

    Next release changes (#281)

commit 07b70af
Author: TADraeseke <tdraeseke@esri.com>
Date:   Mon Dec 23 17:23:45 2024 +0000

    Update samples/animate-images-with-image-overlay/src/main/java/com/esri/arcgismaps/sample/animateimageswithimageoverlay/components/AnimateImagesWithImageOverlayViewModel.kt

    Co-authored-by: Shubham Sharma <shubhamsharma@esri.com>

commit f292e8c
Author: TADraeseke <tdraeseke@esri.com>
Date:   Mon Dec 23 17:19:54 2024 +0000

    Update samples/animate-images-with-image-overlay/src/main/java/com/esri/arcgismaps/sample/animateimageswithimageoverlay/components/AnimateImagesWithImageOverlayViewModel.kt

    Co-authored-by: Shubham Sharma <shubhamsharma@esri.com>

commit 95c11fa
Author: TADraeseke <tdraeseke@esri.com>
Date:   Mon Dec 23 17:17:39 2024 +0000

    Update samples/animate-images-with-image-overlay/src/main/java/com/esri/arcgismaps/sample/animateimageswithimageoverlay/components/AnimateImagesWithImageOverlayViewModel.kt

    Co-authored-by: Shubham Sharma <shubhamsharma@esri.com>

commit 3671366
Author: TADraeseke <tdraeseke@esri.com>
Date:   Mon Dec 23 17:16:23 2024 +0000

    Update samples/animate-images-with-image-overlay/src/main/java/com/esri/arcgismaps/sample/animateimageswithimageoverlay/components/AnimateImagesWithImageOverlayViewModel.kt

    Co-authored-by: Shubham Sharma <shubhamsharma@esri.com>

commit b37e3c9
Author: Shubham Sharma <shubhamsharma@esri.com>
Date:   Fri Dec 20 15:38:01 2024 -0800

    Maybe last set of changes

commit 1f0fb86
Author: Shubham Sharma <shubhamsharma@esri.com>
Date:   Fri Dec 20 15:32:12 2024 -0800

    checker coming in clutch 💪

commit 7283784
Author: Shubham Sharma <shubhamsharma@esri.com>
Date:   Fri Dec 20 15:23:42 2024 -0800

    checker fixes 🕐

commit de71696
Author: Shubham Sharma <shubhamsharma@esri.com>
Date:   Fri Dec 20 15:08:09 2024 -0800

    set ViewModels to top of snippets

commit b025c72
Author: Shubham Sharma <shubhamsharma@esri.com>
Date:   Fri Dec 20 14:58:38 2024 -0800

    Update sample tags to "geoview-compose"

commit 27f6afc
Author: TADraeseke <tdraeseke@esri.com>
Date:   Fri Dec 20 17:39:11 2024 +0000

    Update samples/animate-images-with-image-overlay/src/main/java/com/esri/arcgismaps/sample/animateimageswithimageoverlay/components/AnimateImagesWithImageOverlayViewModel.kt

    Co-authored-by: Shubham Sharma <shubhamsharma@esri.com>

commit 32ce16e
Author: TADraeseke <tdraeseke@esri.com>
Date:   Fri Dec 20 17:38:53 2024 +0000

    Update samples/animate-images-with-image-overlay/src/main/java/com/esri/arcgismaps/sample/animateimageswithimageoverlay/components/AnimateImagesWithImageOverlayViewModel.kt

    Co-authored-by: Shubham Sharma <shubhamsharma@esri.com>

commit d46fe33
Author: TADraeseke <tdraeseke@esri.com>
Date:   Fri Dec 20 17:38:27 2024 +0000

    Update samples/animate-images-with-image-overlay/src/main/java/com/esri/arcgismaps/sample/animateimageswithimageoverlay/components/AnimateImagesWithImageOverlayViewModel.kt

    Co-authored-by: Shubham Sharma <shubhamsharma@esri.com>

commit 50fff19
Author: TADraeseke <tdraeseke@esri.com>
Date:   Fri Dec 20 17:37:35 2024 +0000

    Update samples/animate-images-with-image-overlay/src/main/java/com/esri/arcgismaps/sample/animateimageswithimageoverlay/components/AnimateImagesWithImageOverlayViewModel.kt

    Co-authored-by: Shubham Sharma <shubhamsharma@esri.com>

commit 426d071
Author: TADraeseke <tdraeseke@esri.com>
Date:   Fri Dec 20 17:37:23 2024 +0000

    Update samples/animate-images-with-image-overlay/src/main/java/com/esri/arcgismaps/sample/animateimageswithimageoverlay/screens/AnimateImagesWithImageOverlayScreen.kt

    Co-authored-by: Shubham Sharma <shubhamsharma@esri.com>

commit 52a8c78
Author: TADraeseke <tdraeseke@esri.com>
Date:   Fri Dec 20 17:37:12 2024 +0000

    Update samples/animate-images-with-image-overlay/src/main/java/com/esri/arcgismaps/sample/animateimageswithimageoverlay/screens/AnimateImagesWithImageOverlayScreen.kt

    Co-authored-by: Shubham Sharma <shubhamsharma@esri.com>

commit 7eecb81
Author: TADraeseke <tdraeseke@esri.com>
Date:   Fri Dec 20 17:36:44 2024 +0000

    Update samples/animate-images-with-image-overlay/src/main/java/com/esri/arcgismaps/sample/animateimageswithimageoverlay/screens/AnimateImagesWithImageOverlayScreen.kt

    Co-authored-by: Shubham Sharma <shubhamsharma@esri.com>

commit 636eb7a
Author: TADraeseke <tdraeseke@esri.com>
Date:   Fri Dec 20 17:36:25 2024 +0000

    Update samples/animate-images-with-image-overlay/src/main/java/com/esri/arcgismaps/sample/animateimageswithimageoverlay/components/AnimateImagesWithImageOverlayViewModel.kt

    Co-authored-by: Shubham Sharma <shubhamsharma@esri.com>

commit 41ff89c
Author: TADraeseke <tdraeseke@esri.com>
Date:   Fri Dec 20 17:35:59 2024 +0000

    Update samples/animate-images-with-image-overlay/src/main/java/com/esri/arcgismaps/sample/animateimageswithimageoverlay/DownloadActivity.kt

    Co-authored-by: Shubham Sharma <shubhamsharma@esri.com>

commit 53db5e5
Author: TADraeseke <tdraeseke@esri.com>
Date:   Fri Dec 20 17:35:50 2024 +0000

    Update samples/animate-images-with-image-overlay/README.metadata.json

    Co-authored-by: Shubham Sharma <shubhamsharma@esri.com>

commit 4c2f6a5
Author: Oliver Smith <osmith@esri.com>
Date:   Fri Dec 20 11:24:35 2024 +0000

    Don't go into loading state if layer null

commit bf2d273
Author: Oliver Smith <osmith@esri.com>
Date:   Tue Dec 17 15:57:22 2024 +0000

    Fix README list order

commit 1054b4c
Author: Oliver Smith <osmith@esri.com>
Date:   Tue Dec 17 15:51:13 2024 +0000

    Add newline to end of readme

commit 268b660
Author: Oliver Smith <osmith@esri.com>
Date:   Wed Dec 11 17:33:16 2024 +0000

    Migrate "Query features with Arcade expression" to compose

commit a19b8e3
Author: Trevor Draeseke <trev8939@esri.com>
Date:   Mon Dec 16 17:50:10 2024 -0800

    update README

commit e53a2b6
Author: Trevor Draeseke <trev8939@esri.com>
Date:   Mon Dec 16 17:49:12 2024 -0800

    update README

commit 891b3fd
Author: Trevor Draeseke <trev8939@esri.com>
Date:   Mon Dec 16 17:45:41 2024 -0800

    update README

commit beaea7d
Author: Trevor Draeseke <trev8939@esri.com>
Date:   Mon Dec 16 17:43:20 2024 -0800

    update README

commit 90f66ad
Merge: 8903322 b1f52fb
Author: Trevor Draeseke <trev8939@esri.com>
Date:   Mon Dec 16 17:37:00 2024 -0800

    pull from origin

commit 8903322
Author: Trevor Draeseke <trev8939@esri.com>
Date:   Mon Dec 16 17:24:40 2024 -0800

    update metadata

commit b1f52fb
Merge: f144d9b eb44ba7
Author: TADraeseke <tdraeseke@esri.com>
Date:   Tue Dec 17 01:21:11 2024 +0000

    Merge branch 'v.next' into trev8939/animateImageOverlay

commit f144d9b
Author: Trevor Draeseke <trev8939@esri.com>
Date:   Mon Dec 16 16:35:31 2024 -0800

    file cleanup

commit 3316eb5
Author: Trevor Draeseke <trev8939@esri.com>
Date:   Mon Dec 16 16:33:51 2024 -0800

    file cleanup

commit 4ea0ba6
Author: Trevor Draeseke <trev8939@esri.com>
Date:   Mon Dec 16 16:17:10 2024 -0800

    finished sample

commit eb44ba7
Merge: b511756 8c7a4d7
Author: Alan Lucas <alucas@esri.com>
Date:   Mon Dec 16 10:12:00 2024 +0000

    add-web-tiled-layer: rename Screen & ViewModel classes (#291)

commit b511756
Merge: 5aab24e 81be7cc
Author: Darryl Lynch <dlynch@esri.com>
Date:   Fri Dec 13 18:02:31 2024 +0000

    Update clip geometry sample (#278)

commit 81be7cc
Author: Darryl Lynch <dlynch@esri.com>
Date:   Fri Dec 13 17:59:37 2024 +0000

    Remove MapViewProxy

    It's not really being used, so remove it to reduce complexity

commit 5aab24e
Merge: 0b449b3 74ec8f8
Author: Colin Anderson <colin_anderson@esri.com>
Date:   Fri Dec 13 09:40:18 2024 +0000

    Colinanderson/add raster from file (#288)

commit 0b449b3
Merge: db34189 108e401
Author: Colin Anderson <colin_anderson@esri.com>
Date:   Thu Dec 12 15:44:32 2024 +0000

    Colinanderson/play kml tour compose (#287)

commit 108e401
Author: Colin Anderson <colin_anderson@esri.com>
Date:   Wed Dec 11 18:18:31 2024 +0000

    Be more Kotlin

commit 8aacd89
Author: Colin Anderson <colin_anderson@esri.com>
Date:   Wed Dec 11 18:16:22 2024 +0000

    Organize imports

commit 173f135
Author: Colin Anderson <colin_anderson@esri.com>
Date:   Wed Dec 11 18:15:23 2024 +0000

    Add end of file

commit 065290a
Author: Colin Anderson <colin_anderson@esri.com>
Date:   Wed Dec 11 17:22:14 2024 +0000

    Don't need remember or initial values

commit db34189
Merge: ab024d9 7b4c376
Author: TADraeseke <tdraeseke@esri.com>
Date:   Wed Dec 11 16:43:01 2024 +0000

    Update MapViewModelTemplate.kt (#290)

commit 7b4c376
Author: TADraeseke <tdraeseke@esri.com>
Date:   Wed Dec 11 16:42:53 2024 +0000

    Update MapViewModelTemplate.kt

commit 74ec8f8
Author: Colin Anderson <colin_anderson@esri.com>
Date:   Wed Dec 11 16:17:25 2024 +0000

    Fix the ordering

commit 097e0f8
Author: Colin Anderson <colin_anderson@esri.com>
Date:   Wed Dec 11 16:13:56 2024 +0000

    Code review updates

commit 6cfa664
Author: Colin Anderson <colin_anderson@esri.com>
Date:   Wed Dec 11 16:02:52 2024 +0000

    Renames

commit f4b72f5
Author: Colin Anderson <colin_anderson@esri.com>
Date:   Wed Dec 11 15:13:24 2024 +0000

    Disable play/pause button if the tour is not initialized

commit 6b67e9f
Author: Colin Anderson <colin_anderson@esri.com>
Date:   Wed Dec 11 15:08:03 2024 +0000

    Renames

commit 779898d
Author: Colin Anderson <colin_anderson@esri.com>
Date:   Wed Dec 11 15:03:25 2024 +0000

    Rename from KML to Kml

commit 8c7a4d7
Author: Alan Lucas <alucas@esri.com>
Date:   Wed Dec 11 12:26:00 2024 +0000

    add-web-tiled-layer: update snippets in metadata

commit bd4f097
Author: Alan Lucas <alucas@esri.com>
Date:   Wed Dec 11 09:39:20 2024 +0000

    add-web-tiled-layer: rename Screen & ViewModel classes

commit 458798c
Author: Trevor Draeseke <trev8939@esri.com>
Date:   Tue Dec 10 14:02:10 2024 -0800

    broken UI, but framework in place

commit eb8ac9f
Author: TADraeseke <tdraeseke@esri.com>
Date:   Tue Dec 10 21:47:58 2024 +0000

    Update MapViewModelTemplate.kt

    with TODO reminding that the mutablestate object is only needed if the map is expected to change in this sample

commit c7a27b3
Author: Colin Anderson <colin_anderson@esri.com>
Date:   Tue Dec 10 12:46:36 2024 +0000

    Fix copyright

commit c4cc7ef
Author: Colin Anderson <colin_anderson@esri.com>
Date:   Tue Dec 10 12:14:22 2024 +0000

    Code review updates

commit 5165ccb
Author: Colin Anderson <colin_anderson@esri.com>
Date:   Tue Dec 10 11:18:41 2024 +0000

    End of file

commit 84f6705
Author: Colin Anderson <colin_anderson@esri.com>
Date:   Tue Dec 10 11:17:42 2024 +0000

    No TODO

commit 3685ed8
Author: Colin Anderson <colin_anderson@esri.com>
Date:   Tue Dec 10 09:53:32 2024 +0000

    Tidy up

commit ab024d9
Merge: 0193250 16ab0de
Author: TADraeseke <tdraeseke@esri.com>
Date:   Mon Dec 9 22:09:57 2024 +0000

    Migrate to Compose: Navigate route  (#275)

commit 0193250
Merge: 0086535 7107aa8
Author: Alan Lucas <alucas@esri.com>
Date:   Mon Dec 9 10:25:18 2024 +0000

    Alan/migrate addwebtiledlayer to compose (#284)

commit 7107aa8
Author: Alan Lucas <alucas@esri.com>
Date:   Mon Dec 9 10:22:43 2024 +0000

    add-web-tiled-layer: minor code review fixes

commit 0086535
Merge: 189906e 95a1e18
Author: TADraeseke <tdraeseke@esri.com>
Date:   Fri Dec 6 22:12:31 2024 +0000

    Handle SampleViewer exceptions (#273)

commit a1a374a
Author: Darryl Lynch <dlynch@esri.com>
Date:   Fri Dec 6 17:09:53 2024 +0000

    Use delegation for button variables

commit 39f3554
Author: Darryl Lynch <dlynch@esri.com>
Date:   Fri Dec 6 16:59:24 2024 +0000

    Rename contained to inside

    More consistent with other variable names

commit 2689f80
Author: Darryl Lynch <dlynch@esri.com>
Date:   Fri Dec 6 16:52:28 2024 +0000

    Disable clip button before map finishes loading

commit 9a536bc
Author: Darryl Lynch <dlynch@esri.com>
Date:   Fri Dec 6 16:41:05 2024 +0000

    Optimize imports

commit 4eb6bc1
Author: Darryl Lynch <dlynch@esri.com>
Date:   Fri Dec 6 16:35:37 2024 +0000

    Trim whitespace

commit 95a1e18
Merge: e10457f 189906e
Author: TADraeseke <tdraeseke@esri.com>
Date:   Thu Dec 5 21:07:29 2024 +0000

    Merge branch 'v.next' into shubham/adapt-to-crashes

commit e10457f
Author: Trevor Draeseke <trev8939@esri.com>
Date:   Thu Dec 5 13:06:30 2024 -0800

    remove unused thread arg

commit b138b61
Author: TADraeseke <tdraeseke@esri.com>
Date:   Thu Dec 5 20:58:01 2024 +0000

    Update app/src/main/java/com/esri/arcgismaps/kotlin/sampleviewer/MainActivity.kt

    Co-authored-by: Soren Roth <sroth@esri.com>

commit 189906e
Merge: 1c9bdc8 f5a2bb0
Author: TADraeseke <tdraeseke@esri.com>
Date:   Thu Dec 5 17:27:20 2024 +0000

    Update entry.py (#289)

commit f5a2bb0
Author: TADraeseke <tdraeseke@esri.com>
Date:   Thu Dec 5 17:24:54 2024 +0000

    Update entry.py

commit fbf345f
Author: Colin Anderson <colin_anderson@esri.com>
Date:   Thu Dec 5 16:37:14 2024 +0000

    Image and readme

commit 09cdb82
Author: Colin Anderson <colin_anderson@esri.com>
Date:   Thu Dec 5 13:14:06 2024 +0000

    Add raster from file sample

commit 11e52d9
Author: Colin Anderson <colin_anderson@esri.com>
Date:   Thu Dec 5 09:54:55 2024 +0000

    Scene doesn't need to be mutable state

commit d49c3bf
Author: Colin Anderson <colin_anderson@esri.com>
Date:   Wed Dec 4 15:26:43 2024 +0000

    Update the metadata to hopefully fix PR check

commit 13b6dff
Author: Colin Anderson <colin_anderson@esri.com>
Date:   Wed Dec 4 14:57:24 2024 +0000

    Update readme and metadata

commit ec7f5fb
Author: Alan Lucas <alucas@esri.com>
Date:   Wed Dec 4 14:35:47 2024 +0000

    add-web-tiled-layer: change screenshot

commit 2da0096
Merge: 05c43fd 1c9bdc8
Author: Colin Anderson <colin_anderson@esri.com>
Date:   Wed Dec 4 14:28:04 2024 +0000

    Merge branch 'v.next' into colinanderson/play_kml_tour_compose

commit 05c43fd
Author: Colin Anderson <colin_anderson@esri.com>
Date:   Wed Dec 4 14:26:45 2024 +0000

    Manifest

commit 01c26d2
Author: Colin Anderson <colin_anderson@esri.com>
Date:   Wed Dec 4 14:19:11 2024 +0000

    Add the new files

commit 187c004
Author: Colin Anderson <colin_anderson@esri.com>
Date:   Wed Dec 4 13:37:59 2024 +0000

    Replace old implementation with new compose implementation

commit a0bf813
Author: Alan Lucas <alucas@esri.com>
Date:   Wed Dec 4 11:52:47 2024 +0000

    add-web-tiled-layer: no need for mutable state in MapViewModel

commit 3f810ae
Author: Darryl Lynch <dlynch@esri.com>
Date:   Wed Dec 4 11:26:12 2024 +0000

    Reduce code in init block

    -Move creation of Colorado graphic and envelopes out of init block

    -Remove call to reset() in init block in favour of apply during during declaration

commit 9c95eed
Author: Darryl Lynch <dlynch@esri.com>
Date:   Wed Dec 4 11:21:17 2024 +0000

    Inline graphics overlay collection

commit 5fb9a71
Author: Alan Lucas <alucas@esri.com>
Date:   Wed Dec 4 11:21:09 2024 +0000

    add-web-tiled-layer: update README.metadata.json

commit 8e38a6c
Author: Darryl Lynch <dlynch@esri.com>
Date:   Wed Dec 4 11:08:20 2024 +0000

    Fix comment grammar

    Co-authored-by: TADraeseke <tdraeseke@esri.com>

commit 348da27
Author: Darryl Lynch <dlynch@esri.com>
Date:   Wed Dec 4 11:07:57 2024 +0000

    More detail in comment

    Co-authored-by: TADraeseke <tdraeseke@esri.com>

commit de11a24
Author: Darryl Lynch <dlynch@esri.com>
Date:   Wed Dec 4 11:07:40 2024 +0000

    Change whitespace

    Co-authored-by: TADraeseke <tdraeseke@esri.com>

commit e9423e0
Author: Colin Anderson <colin_anderson@esri.com>
Date:   Wed Dec 4 10:10:32 2024 +0000

    Clean up

commit d9a2ae5
Author: Alan Lucas <alucas@esri.com>
Date:   Wed Dec 4 10:04:59 2024 +0000

    add-web-tiled-layer: minor changes to README.md

commit 715f64c
Author: Alan Lucas <alucas@esri.com>
Date:   Wed Dec 4 09:35:32 2024 +0000

    add-web-tiled-layer: rename classes to MainScreen & MapViewModel

commit d4de4e8
Author: Colin Anderson <colin_anderson@esri.com>
Date:   Tue Dec 3 17:15:06 2024 +0000

    Screenshot

commit 7c5eda4
Author: Colin Anderson <colin_anderson@esri.com>
Date:   Tue Dec 3 17:10:13 2024 +0000

    Change basemap and add comments

commit 6ebc388
Author: Alan Lucas <alucas@esri.com>
Date:   Tue Dec 3 12:12:17 2024 +0000

    add-web-tiled-layer: make all tags lower case

commit 416b1c0
Author: Alan Lucas <alucas@esri.com>
Date:   Tue Dec 3 10:39:43 2024 +0000

    add-web-tiled-layer: add tags in README.md

commit 588f113
Author: Alan Lucas <alucas@esri.com>
Date:   Tue Dec 3 10:38:54 2024 +0000

    add-web-tiled-layer: fix code formatting

commit 93069b6
Author: Alan Lucas <alucas@esri.com>
Date:   Tue Dec 3 10:37:07 2024 +0000

    add-web-tiled-layer: update screenshot

commit 120b781
Author: Colin Anderson <colin_anderson@esri.com>
Date:   Mon Dec 2 17:43:57 2024 +0000

    Readme and metadata

commit 85e1f2f
Author: Alan Lucas <alucas@esri.com>
Date:   Mon Dec 2 17:29:45 2024 +0000

    Migrate add-web-tiled-layer sample to Compose

commit 36c0505
Author: Colin Anderson <colin_anderson@esri.com>
Date:   Mon Dec 2 16:38:38 2024 +0000

    Add downloader to metadata

commit 51d5f0d
Author: Colin Anderson <colin_anderson@esri.com>
Date:   Mon Dec 2 14:57:30 2024 +0000

    Use provisioning location

commit 21328e7
Author: Colin Anderson <colin_anderson@esri.com>
Date:   Mon Dec 2 13:36:07 2024 +0000

    Add downlaod activity to manifest

commit 84e6e9c
Author: Colin Anderson <colin_anderson@esri.com>
Date:   Mon Dec 2 13:33:27 2024 +0000

    Downloade activity

commit ce9c14d
Author: Darryl Lynch <dlynch@esri.com>
Date:   Fri Nov 29 14:54:23 2024 +0000

    Use function level comments

commit ebaf7b3
Author: Darryl Lynch <dlynch@esri.com>
Date:   Fri Nov 29 14:50:32 2024 +0000

    Remove unnecessary mutableStateOf

commit de61c17
Author: Darryl Lynch <dlynch@esri.com>
Date:   Fri Nov 29 14:48:55 2024 +0000

    Let Android handle viewModel creation

commit 0c39be7
Author: Darryl Lynch <dlynch@esri.com>
Date:   Fri Nov 29 14:28:38 2024 +0000

    Fix line length

    Co-authored-by: TADraeseke <tdraeseke@esri.com>

commit 5196e3c
Author: Darryl Lynch <dlynch@esri.com>
Date:   Fri Nov 29 14:23:46 2024 +0000

    Remove unneeded padding

commit 2c09daa
Author: Darryl Lynch <dlynch@esri.com>
Date:   Fri Nov 29 14:17:34 2024 +0000

    Fix whitespace

    Co-authored-by: TADraeseke <tdraeseke@esri.com>

commit 4e9a653
Author: Darryl Lynch <dlynch@esri.com>
Date:   Fri Nov 29 14:16:09 2024 +0000

    Cleanup whitespace

    Co-authored-by: TADraeseke <tdraeseke@esri.com>

commit 97576c4
Author: Darryl Lynch <dlynch@esri.com>
Date:   Fri Nov 29 14:11:01 2024 +0000

    Update README.metadata.json

commit 7079cf7
Author: Darryl Lynch <dlynch@esri.com>
Date:   Fri Nov 29 13:57:58 2024 +0000

    Move hardcoded strings to string resources

commit 9e473c5
Author: Colin Anderson <colin_anderson@esri.com>
Date:   Thu Nov 28 11:43:09 2024 +0000

    Formatting and don't need to use emit

commit 5ce36d3
Author: Colin Anderson <colin_anderson@esri.com>
Date:   Wed Nov 27 18:15:19 2024 +0000

    Disable/enable reset button

commit 25ac699
Author: Colin Anderson <colin_anderson@esri.com>
Date:   Wed Nov 27 17:27:38 2024 +0000

    Add icons

commit b2853bc
Author: Colin Anderson <colin_anderson@esri.com>
Date:   Wed Nov 27 16:55:32 2024 +0000

    Layout and use the flow to detrmine play/pause button

commit 044dff0
Author: Colin Anderson <colin_anderson@esri.com>
Date:   Wed Nov 27 14:06:29 2024 +0000

    Implement reset, renames etc.

commit 6164dd2
Author: Colin Anderson <colin_anderson@esri.com>
Date:   Tue Nov 26 14:41:26 2024 +0000

    Use flows for status and progress

commit 1c9bdc8
Author: Shubham Sharma <shubhamsharma@esri.com>
Date:   Mon Nov 25 12:32:15 2024 -0800

    Update NewModuleScript (#270)

commit 3ea40b5
Author: Colin Anderson <colin_anderson@esri.com>
Date:   Mon Nov 25 16:02:59 2024 +0000

    Tour can now play

commit 9d1bc82
Author: Mark Dugger <mdugger@esri.com>
Date:   Fri Nov 22 16:13:37 2024 -0800

    Fix GeodatabaseSyncTask link so it points to Kotlin API Ref instead of Java API Ref (#279)

commit 16ab0de
Author: Shubham Sharma <shubhamsharma@esri.com>
Date:   Fri Nov 22 10:58:18 2024 -0800

    added comment

commit 0da3bab
Author: Shubham Sharma <shubhamsharma@esri.com>
Date:   Fri Nov 22 09:34:24 2024 -0800

    add scaling fix by disabling autopan on reset

commit 917c7b9
Author: Darryl Lynch <dlynch@esri.com>
Date:   Wed Nov 20 15:56:07 2024 +0000

    Add more comments

commit 08f6ffe
Author: Darryl Lynch <dlynch@esri.com>
Date:   Wed Nov 20 14:55:19 2024 +0000

    Make coloradoGraphic non-nullable

commit da8491c
Author: Darryl Lynch <dlynch@esri.com>
Date:   Wed Nov 20 14:54:18 2024 +0000

    Reduce code duplication

commit f76bc11
Author: Darryl Lynch <dlynch@esri.com>
Date:   Wed Nov 20 14:50:57 2024 +0000

    First draft of updated clip geometry

commit 80a5f46
Author: Darryl Lynch <dlynch@esri.com>
Date:   Wed Nov 20 12:04:34 2024 +0000

    Replace old clip geometry with compose starter

commit 97d2931
Merge: d7f2859 341d05e
Author: TADraeseke <tdraeseke@esri.com>
Date:   Thu Nov 21 21:35:16 2024 +0000

    Trev8939/handle async samples list (#276)

commit 3e30bce
Author: Shubham Sharma <shubhamsharma@esri.com>
Date:   Wed Nov 20 17:25:41 2024 -0800

    PR feedback changes

commit fac3289
Merge: 0279937 d7f2859
Author: Shubham Sharma <shubhamsharma@esri.com>
Date:   Wed Nov 20 16:51:10 2024 -0800

    Merge branch 'v.next' into shubham/migrate-navigate-route

commit d7f2859
Merge: d58b83c 3534159
Author: TADraeseke <tdraeseke@esri.com>
Date:   Wed Nov 20 19:18:49 2024 +0000

    Migrate to Compose: Display map from mobile map package (#272)

commit 3534159
Author: TADraeseke <tdraeseke@esri.com>
Date:   Wed Nov 20 19:14:35 2024 +0000

    Update samples/display-map-from-mobile-map-package/src/main/java/com/esri/arcgismaps/sample/displaymapfrommobilemappackage/screens/MainScreen.kt

    Co-authored-by: Shubham Sharma <shubhamsharma@esri.com>

commit 24e4189
Merge: f0a6fb0 d58b83c
Author: TADraeseke <tdraeseke@esri.com>
Date:   Wed Nov 20 17:40:50 2024 +0000

    Merge branch 'v.next' into trev8939/displayMapFromMobileMapPackageCompose

commit f0a6fb0
Author: Trevor Draeseke <trev8939@esri.com>
Date:   Wed Nov 20 09:38:08 2024 -0800

    README ordering

commit 0dfa0f7
Author: Trevor Draeseke <trev8939@esri.com>
Date:   Wed Nov 20 09:35:46 2024 -0800

    remove salive file

commit 6b6908f
Merge: aa8865d 6b0047b
Author: Trevor Draeseke <trev8939@esri.com>
Date:   Wed Nov 20 09:34:24 2024 -0800

    pull from origin

commit aa8865d
Author: Trevor Draeseke <trev8939@esri.com>
Date:   Wed Nov 20 09:33:22 2024 -0800

    remove mapview proxy and fix metadata

commit 6b0047b
Author: TADraeseke <tdraeseke@esri.com>
Date:   Wed Nov 20 00:05:15 2024 +0000

    Update build.gradle.kts

commit 48e9fba
Author: TADraeseke <tdraeseke@esri.com>
Date:   Wed Nov 20 00:03:05 2024 +0000

    Update build.gradle.kts

commit 468f4ca
Author: Trevor Draeseke <trev8939@esri.com>
Date:   Tue Nov 19 16:02:28 2024 -0800

    remove autogenerated files

commit da56264
Author: Trevor Draeseke <trev8939@esri.com>
Date:   Tue Nov 19 16:01:39 2024 -0800

    PR fixes

commit d58b83c
Author: Shubham Sharma <shubhamsharma@esri.com>
Date:   Tue Nov 19 15:56:39 2024 -0800

    Report if key is not set (#274)

commit 341d05e
Author: Trevor Draeseke <trev8939@esri.com>
Date:   Tue Nov 19 11:49:36 2024 -0800

    encapsulate

commit 4bf6368
Author: Trevor Draeseke <trev8939@esri.com>
Date:   Tue Nov 19 11:21:14 2024 -0800

    wrap getSampleByName and getSampleByCategory in flows and observe in UI

commit 0279937
Author: Shubham Sharma <shubhamsharma@esri.com>
Date:   Tue Nov 19 11:18:24 2024 -0800

    more checker fixes

commit f1bad23
Author: Shubham Sharma <shubhamsharma@esri.com>
Date:   Tue Nov 19 11:12:05 2024 -0800

    checker fix

commit a65ca4c
Author: Shubham Sharma <shubhamsharma@esri.com>
Date:   Tue Nov 19 11:06:51 2024 -0800

    added doc changes

commit 3e9f7c3
Author: Shubham Sharma <shubhamsharma@esri.com>
Date:   Tue Nov 19 10:46:10 2024 -0800

    migrated sample

commit 21f95db
Author: Shubham Sharma <shubhamsharma@esri.com>
Date:   Mon Nov 18 17:39:14 2024 -0800

    revert Sample.kt

commit 5b86e13
Author: Shubham Sharma <shubhamsharma@esri.com>
Date:   Mon Nov 18 16:44:26 2024 -0800

    added doc and cleanup

commit 2df7ab1
Author: Shubham Sharma <shubhamsharma@esri.com>
Date:   Mon Nov 18 16:32:12 2024 -0800

    added exception dialog

commit 24b4904
Author: Shubham Sharma <shubhamsharma@esri.com>
Date:   Mon Nov 18 15:09:06 2024 -0800

    testing a fix

commit a7a995b
Author: Trevor Draeseke <trev8939@esri.com>
Date:   Mon Nov 18 08:47:01 2024 -0800

    new lines at end of files

commit 75de024
Author: Trevor Draeseke <trev8939@esri.com>
Date:   Mon Nov 18 08:44:42 2024 -0800

    README and metadata format fixes

commit 2dfe42a
Author: Trevor Draeseke <trev8939@esri.com>
Date:   Fri Nov 15 09:58:29 2024 -0800

    update README and metadata for display map from mobile map package

commit 3cea5b8
Author: Trevor Draeseke <trev8939@esri.com>
Date:   Thu Nov 14 16:47:19 2024 -0800

    migrate Display map from mobile map package

commit cb73624
Author: Shubham Sharma <shubhamsharma@esri.com>
Date:   Wed Nov 13 17:28:29 2024 -0800

    200.6.0 Release Changes (#266)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TADraeseke TADraeseke TADraeseke approved these changes

@puneet-pdx puneet-pdx puneet-pdx approved these changes

Assignees

@shubham7109 shubham7109

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shubham7109 @puneet-pdx @TADraeseke