Migrate sample: Find route #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TADraeseke
requested changes
Jan 13, 2025
...nd-route/src/main/java/com/esri/arcgismaps/sample/findroute/components/FindRouteViewModel.kt
Outdated
Show resolved
Hide resolved
...nd-route/src/main/java/com/esri/arcgismaps/sample/findroute/components/FindRouteViewModel.kt
Outdated
Show resolved
Hide resolved
...nd-route/src/main/java/com/esri/arcgismaps/sample/findroute/components/FindRouteViewModel.kt
Show resolved
Hide resolved
...les/find-route/src/main/java/com/esri/arcgismaps/sample/findroute/screens/FindRouteScreen.kt
Outdated
Show resolved
Hide resolved
|
@TADraeseke I added in the feedback comments, ready for your review. Regarding the solve route button, I had intentionally kept it enabled to allow for repeated route solves which then updates the map's viewpoint to the result. If you find it unintuitive, I can disable the button after the first solve. |
sorenoid
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR to migrate the Find route sample to Compose
Links and Data
Sample issue: #5010