Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Patch] Create and save map #237

Merged
merged 2 commits into from
Oct 9, 2024
Merged

[Patch] Create and save map #237

merged 2 commits into from
Oct 9, 2024

Conversation

01smito01
Copy link
Collaborator

Description

Updates Create and Save Map to unset API key & invalidate any existing OAuth credentials, making it play nice with the sample viewer.

Links and Data

Sample Epic: #2922

  • a vTest Job for this PR has been run

What To Review

  • Is it sensible to use runBlocking like this? I had wanted to use lifetimeScope, but that caused the authenticator to loop indefinitely when re-running the sample in the viewer. This may cause a small delay when re-running the sample in the viewer.
  • Does the sample work properly in the viewer?
    • In particular, does it behave as expected before and after running "Authenticate with OAuth", which sets an API key and authenticates the user?

How to Test

Run the sample in the sample viewer.

@01smito01 01smito01 added the Patch A patch to an existing sample label Oct 7, 2024
@01smito01 01smito01 requested a review from shubham7109 October 7, 2024 16:16
Copy link
Collaborator

@shubham7109 shubham7109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks @01smito01

@shubham7109
Copy link
Collaborator

@01smito01 Tested using the build from the vTest, both samples load without errors. We should use a similar fix for the authenticate-with-oauth & show-portal-user-info samples, to prevent the cached oauth login to persist between samples.

@01smito01 01smito01 merged commit e33cffb into v.next Oct 9, 2024
1 check passed
@01smito01 01smito01 deleted the oliver/create-and-save-map branch October 9, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Patch A patch to an existing sample
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants