Update to use GeoviewCompose - SceneView #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruiqima
reviewed
Apr 1, 2024
...in/java/com/esri/arcgismaps/sample/showviewshedfrompointinscene/components/SceneViewModel.kt
Outdated
Show resolved
Hide resolved
.../src/main/java/com/esri/arcgismaps/sample/showviewshedfrompointinscene/screens/MainScreen.kt
Show resolved
Hide resolved
...ain/java/com/esri/arcgismaps/sample/displayscenefrommobilescenepackage/screens/MainScreen.kt
Show resolved
Hide resolved
...a/com/esri/arcgismaps/sample/displayscenefrommobilescenepackage/components/SceneViewModel.kt
Show resolved
Hide resolved
...on/src/main/java/com/esri/arcgismaps/sample/addscenelayerwithelevation/screens/MainScreen.kt
Show resolved
Hide resolved
|
Thanks, @ruiqima, I addressed the feedback. Ready for your review |
prupani-7
reviewed
Apr 1, 2024
There was a problem hiding this comment.
@shubham7109 Looks good, one minor comment about the extra line.
Other comment:
-
For the
show-viewshed-from-point-in-scenesample, I noticed a typo inintialSliderValuein theViewshedSlider.ktfile, should beinitialSliderValue
since we are making changes to this file, it will be good to address this minor typo as well. -
In the same file, (ignore this comment, I see its been addressed here)
var sliderValue by remember {
mutableStateOf(intialSliderValue)
}
could be modified to
var sliderValue by remember {
mutableFloatStateOf(intialSliderValue)
}
.../src/main/java/com/esri/arcgismaps/sample/showviewshedfrompointinscene/screens/MainScreen.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR to update the 3 missed SceneView compose samples to use geoview-compose SceneView:
Links and Data
Sample issue:
runtime/kotlin/issues/3776