Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename feature reduction sample to Display Clusters #190

Merged
merged 4 commits into from
Apr 1, 2024

Conversation

prupani-7
Copy link

Description

PR to rename Display points using clustering feature reduction to Display clusters

Links and Data

Sample Epic: runtime/kotlin/issues/3691

What To Review

  • Review the code changes
  • README.md and README.metadata.json files

How to Test

Run the sample on the sample viewer or the repo.

@prupani-7 prupani-7 requested a review from shubham7109 March 29, 2024 17:40
@ruiqima
Copy link

ruiqima commented Apr 1, 2024

Should we update the screenshot pngs? The disable button now is a toggle button looks like this, different from display-clusters-main.png.
image

And in display-clusters-popup.png, the app title is still the old name.

Copy link

@ruiqima ruiqima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one minor comment about screenshots.

@prupani-7
Copy link
Author

@ruiqima that was a good find. Thanks! Updated the screenshots.

@prupani-7 prupani-7 merged commit 5c8cefd into v.next Apr 1, 2024
1 check passed
@prupani-7 prupani-7 deleted the pri/updatesamplename branch April 1, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants