-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename geo-compose -> geoview-compose #182
Rename geo-compose -> geoview-compose #182
Conversation
Seems like the style checker errors are false positives?
The readme tags seem sorted, and so do the keywords in metadata json file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment about tag reordering, others looks good 👍 Tested with sample viewer, it built successfully.
Context for other reviewers: updates related to NewModuleScript will be handled in a separate issue, as there requires some other changes too.
Thanks Ruiqi, I easily overlooked that! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work @prupani-7
I see some more references to geocompose
in MainScreenTemplate.kt
and in .github/.../Main.yaml
here.
do these need to be updated?
as mentioned above the MainScreenTemplate.kt update within the tools\NewModuleScript folder will be handled by Ruiqi's PR. And the Main.yml has just a mention about the branch name which is still |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼
Description
PR to rename geo-compose -> geoview-compose
Links and Data
Sample Epic:
runtime/kotlin/issues/3653
What To Review
How to Test
Run the affected sample on the sample viewer or the repo.