Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update show coordinated in multiple formats sample #174

Merged
merged 3 commits into from
Mar 11, 2024
Merged

Update show coordinated in multiple formats sample #174

merged 3 commits into from
Mar 11, 2024

Conversation

ruiqima
Copy link

@ruiqima ruiqima commented Mar 6, 2024 •
edited
Loading

Description

PR to revisit sample to reflect new changes in Kotlin toolkit.

Links and Data

#3586

What To Review

  • Build and run the sample to check for any errors.
  • Update the MapViewModel to be able to work with the geo-compose module.
  • Add the line to the "Additional information section": This sample uses the GeoCompose Toolkit module to be able to implement a Composable MapView.
  • Replace the application parameter from the MainScreen with the use of LocalContext.current.applicationContext
  • Add the tags: geocompose, tookit
  • Update the sample's metadata.json file to reflect file and tags changes

How to Test

Run the sample on the sample viewer or the repo.

prupani-7
prupani-7 approved these changes Mar 7, 2024
View reviewed changes
Copy link

@prupani-7 prupani-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

shubham7109
shubham7109 approved these changes Mar 8, 2024
View reviewed changes
Copy link
Collaborator

@shubham7109 shubham7109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 just one minor change:

.../main/java/com/esri/arcgismaps/sample/showcoordinatesinmultipleformats/screens/MainScreen.kt Outdated Show resolved Hide resolved
@ruiqima ruiqima merged commit ac17144 into feature-branch/geo-compose Mar 11, 2024
1 check passed
@ruiqima ruiqima deleted the ruiqi/revisit-show-coordinated-in-mutliple-formats branch March 11, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubham7109 shubham7109 shubham7109 approved these changes

@prupani-7 prupani-7 prupani-7 approved these changes

Assignees

@ruiqima ruiqima

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ruiqima @shubham7109 @prupani-7