Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foreground service type patch - v.next #165

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

ruiqima
Copy link

@ruiqima ruiqima commented Feb 8, 2024

Description

PR to fix the crashing of sample generate-offline-map-using-android-jetpack-workmanager when running on Android 14 (API level 34) devices.

Links and Data

#3463

What To Review

  • The correct ForegroundServiceType is used. View all available type here.
  • Sample generate-offline-map-using-android-jetpack-workmanager is running on both Android 13 and 14 devices, and the job can execute as expected.

How to Test

Run the sample on the sample viewer or the repo.

@ruiqima ruiqima changed the title Foreground service type patch Foreground service type patch - v.next Feb 8, 2024
@ruiqima ruiqima marked this pull request as ready for review February 13, 2024 01:35
@shubham7109 shubham7109 added the Patch A patch to an existing sample label Feb 13, 2024
Copy link
Collaborator

@shubham7109 shubham7109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to approve. Sample is working fine on the latest and the old API versions for me.

@puneet-pdx puneet-pdx self-requested a review February 15, 2024 18:20
@ruiqima ruiqima merged commit a3c71e2 into v.next Feb 16, 2024
1 check passed
@ruiqima ruiqima deleted the ruiqi/foregroundservice-type-patch branch February 16, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Patch A patch to an existing sample
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants