Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sample - add dynamic entity sample #161

Merged

Conversation

prupani-7
Copy link

Description

PR to update the sample to use composable mapview from the toolkit

Links and Data

Sample Epic: runtime/kotlin/issues/3361

What To Review

Review updated files

How to Test

Run the sample on the sample viewer or the repo.

@prupani-7 prupani-7 changed the base branch from main to feature-branch/geo-compose December 21, 2023 23:55
Copy link

@ruiqima ruiqima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@XuemingRocks XuemingRocks self-requested a review December 29, 2023 17:09
Copy link
Collaborator

@XuemingRocks XuemingRocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@prupani-7 prupani-7 merged commit e036ee7 into feature-branch/geo-compose Dec 29, 2023
1 check passed
@prupani-7 prupani-7 deleted the priy/updateAddDynamicEntitySample branch December 29, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants