Update sample - query feature table #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubham7109
requested changes
Dec 20, 2023
There was a problem hiding this comment.
Replace the application parameter from the MainScreen with the use of LocalContext.current.applicationContext
Comment on lines
72
to
73
| // define a MapViewpointOperation to set the initial viewpoint and update it when the viewpoint changes | ||
| var mapViewpointOperation: MapViewpointOperation? by mutableStateOf(null) |
There was a problem hiding this comment.
The mapViewpointOperation here does not need to be nullable, you could set it to the initial viewpoint. And remove it from the init block.
Suggested change
| // define a MapViewpointOperation to set the initial viewpoint and update it when the viewpoint changes | |
| var mapViewpointOperation: MapViewpointOperation? by mutableStateOf(null) | |
| // define a mutable MapViewpointOperation and set the initial viewpoint | |
| var mapViewpointOperation: MapViewpointOperation by mutableStateOf( | |
| MapViewpointOperation.Set(usaViewpoint) | |
| ) |
| @@ -113,28 +124,13 @@ class MapViewModel( | |||
| // get the extent of the first feature in the result to zoom to | |||
| val envelope = feature.geometry?.extent | |||
| ?: return@launch messageDialogVM.showMessageDialog("Error retrieving geometry extent") | |||
| // update the map view to set the viewpoint to the state geometry | |||
| mapViewState.stateGeometry = envelope | |||
| // update the MapViewpointOperation to set the geometry of the returned feature | |||
There was a problem hiding this comment.
"set the geometry of the returned feature" doesn't sound right to me here. Maybe the comment could be:
Suggested change
| // update the MapViewpointOperation to set the geometry of the returned feature | |
| // update the viewpoint to the bounding geometry of the returned feature |
| */ | ||
| class MapViewState { | ||
| // map used to display the feature layer | ||
| var arcGISMap: ArcGISMap by mutableStateOf(ArcGISMap(BasemapStyle.ArcGISTopographic)) | ||
|
|
|
@shubham7109 Applied the suggestions, thanks! a re-review? |
shubham7109
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR to update the sample to use composable mapview from the toolkit
Links and Data
Sample Epic:
runtime/kotlin/issues/3366What To Review
Review updated files
How to Test
Run the sample on the sample viewer or the repo.