Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sample - Display points using feature reduction #158

Merged

Conversation

prupani-7
Copy link

@prupani-7 prupani-7 commented Dec 19, 2023

Description

PR to update the sample to use composable mapview from the toolkit
Use "arcgisToolkitVersion = '200.4.0-1'" for MapView Identofy operations
Removed the show Loading Dialog when Map is loaded from prev sample implementation with removal of init block. It was added just as an enhancement to the sample.
Rename the png file, for checker to pass and also sample viewer will show the first image as display for the app

Links and Data

Sample Epic: runtime/kotlin/issues/3363

What To Review

Review updated files

How to Test

Run the sample on the sample viewer or the repo.

@shubham7109 shubham7109 added the enhancement New feature or request label Dec 20, 2023
@shubham7109 shubham7109 self-requested a review December 20, 2023 23:18
@prupani-7 prupani-7 changed the title update feature reduction sample Update sample - Display points using feature reduction Dec 21, 2023
@XuemingRocks XuemingRocks self-requested a review December 27, 2023 18:58
Copy link
Collaborator

@XuemingRocks XuemingRocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Just a minor suggestion.

@prupani-7
Copy link
Author

Thanks for the reviews, @shubham7109 and @XuemingRocks ..Merging

@prupani-7 prupani-7 merged commit 28ae7c4 into feature-branch/geo-compose Dec 28, 2023
1 check passed
@prupani-7 prupani-7 deleted the pri/update-feature-reduction-sample branch December 28, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants