Samples Post Release Tasks #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ignoring build checker failure since it is reading the main readme file. |
hud10837
approved these changes
Dec 13, 2023
gunt0001
reviewed
Dec 13, 2023
prupani-7
reviewed
Dec 14, 2023
| @@ -1,14 +1,14 @@ | |||
| ext { | |||
There was a problem hiding this comment.
While reviewing the other PR https://devtopia.esri.com/runtime/kotlin/pull/3392/files, I was verifying myself to see if samples, toolkit and kotlin repo versions.gradle match. came across this PR
I noticed, below three version that need to be updated to match the other version upgrades?
androidBrowserVersion = '1.5.0'
// Plugin versions
gradleVersion = '8.1.1'
// Java version
javaVersion = 1.17
to
androidBrowserVersion = '1.7.0'
// Plugin versions
gradleVersion = '8.2.0'
// Java version
javaVersion = 1.8
|
@prupani-7 Let's update dependencies in a separate PR once the SDK changes are added. This PR is to allow for daily builds to run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.