update new module script to use geo-compose toolkit component #148

prupani-7 · 2023-12-06T23:22:01Z

Description

PR to update the new module script to spin up new samples using the geo-compose toolkit module by default.

Links and Data

Sample Epic: runtime/kotlin/issues/3370

What To Review

Review script files

How to Test

Test if the JAR creates a new sample as expected.
To run the script and create a new sample:
java -jar tools/NewModuleScript.jar
The .jar file will prompt you to type in the name of the new sample.

shubham7109

Few minor change requests. The script runs well, and the sample works using geo-compose.

shubham7109 · 2023-12-11T23:29:54Z

...le-mapview/src/main/java/com/esri/arcgismaps/sample/displaycomposablemapview/MainActivity.kt

I like the new module created when the script is used, but I don't think it should require any sample changes. The DisplayComposableMapView sample should be a basic implementation of the DisplayMap sample, i.e. render a map with a basemap style.

The module script can spin up a sample with touch event implementation, but let's keep this sample similar to DisplayMap with the geo-compose module.

I am fine with this change. Although with the previous version of display-composable-mapview sample, we did have the touch event implementation in addition to displaying the map with a particular basemap style. Not sure if there was any particular intention of doing it that way back then? But I too feel it should be similar to the display map sample.

shubham7109 · 2023-12-11T23:34:05Z

display-composable-mapview/build.gradle

@@ -45,4 +45,7 @@ dependencies {
    implementation "androidx.compose.ui:ui-tooling"
    implementation "androidx.compose.ui:ui-tooling-preview"
    implementation project(path: ':samples-lib')
+    // Toolkit dependencies
+    implementation(platform("com.esri:arcgis-maps-kotlin-toolkit-bom:200.3.0-1"))


Could you update this sample with the flag arcgisToolkitVersion and update the versions.gradle with the build tag of geo-compose:

Suggested change

implementation(platform("com.esri:arcgis-maps-kotlin-toolkit-bom:200.3.0-1"))

implementation(platform("com.esri:arcgis-maps-kotlin-toolkit-bom:$arcgisToolkitVersion"))

prupani-7 · 2023-12-12T19:55:01Z

@shubham7109 Thanks, please re-review?

shubham7109

One minor change request, PR looks good 👍

...le-mapview/src/main/java/com/esri/arcgismaps/sample/displaycomposablemapview/MainActivity.kt

…ample/displaycomposablemapview/MainActivity.kt Co-authored-by: Shubham Sharma <shubhamsharma@esri.com>

shubham7109 · 2023-12-13T21:48:00Z

Could you update the snippets tag in the metada.json here as well? I'll update the tasks to mention this step.

puneet-pdx · 2023-12-13T23:43:40Z

version.gradle

@@ -2,7 +2,7 @@ ext {
    // ArcGIS Maps SDK for Kotlin version
    arcgisVersion = '200.3.0-4075'
    // ArcGIS Maps SDK for Kotlin Toolkit version
-    arcgisToolkitVersion = '200.3.0-4075'
+    arcgisToolkitVersion = '200.3.0-1'


shouldn't this be 200.3.0 ?

200.3.0-1 is the published toolkit version where the geo-compose MapView is available
https://devtopia.esri.com/runtime/kotlin/issues/3358#issuecomment-4463774

puneet-pdx · 2023-12-13T23:46:22Z

...ava/com/esri/arcgismaps/sample/showcoordinatesinmultipleformats/components/ComposeMapView.kt

- * Wraps the MapView in a Composable function.
- */
-@Composable
-fun ComposeMapView(


this sample showcoordinatesinmultipleformats is still referring to this fun and has a compilation error because of this removal.

got falsely committed, reverted.

puneet-pdx · 2023-12-13T23:48:39Z

tools/NewModuleScript/src/main/java/ScriptMain.java

@@ -111,9 +110,6 @@ private void createFilesAndFolders() {

            File composeComponentsDir = new File(packageDirectory + "/components");


should this be renamed to componentsDir ?

prupani-7 · 2023-12-14T00:04:09Z

@puneet-pdx There might be some merge issues, as Shubham recently merged main into the feature-branch/geo-compose. I will merge my branch with the latest feature-branch/geo-compose, which should resolve some errors.
[DONE]

prupani-7 · 2023-12-14T00:25:37Z

@puneet-pdx thank you, a re-review?
Also note, I have updated version.gradle file with arcGISVersion changes, in this PR

Once this PR is merged, I will merge the subsequent PR's I have open with the feature branch.

prupani-7 added 2 commits December 6, 2023 15:07

Update newmodulescript

25b8e02

jar

5e0e282

prupani-7 changed the title ~~Pri/update new module script~~ update new module script to use geo-compose toolkit component Dec 7, 2023

shubham7109 assigned prupani-7 Dec 7, 2023

shubham7109 self-requested a review December 7, 2023 22:40

shubham7109 added the enhancement New feature or request label Dec 7, 2023

prupani-7 changed the base branch from v.next to feature-branch/geo-compose December 7, 2023 23:06

shubham7109 reviewed Dec 11, 2023

View reviewed changes

prupani-7 added 2 commits December 12, 2023 11:51

feedback

020edcf

add commnet

43b6c11

prupani-7 requested a review from shubham7109 December 12, 2023 19:54

This was referenced Dec 12, 2023

update show magnifier sample #149

Merged

Update show coordinates sample #152

Merged

shubham7109 approved these changes Dec 13, 2023

View reviewed changes

...le-mapview/src/main/java/com/esri/arcgismaps/sample/displaycomposablemapview/MainActivity.kt Outdated Show resolved Hide resolved

Update display-composable-mapview/src/main/java/com/esri/arcgismaps/s…

b14cd8d

…ample/displaycomposablemapview/MainActivity.kt Co-authored-by: Shubham Sharma <shubhamsharma@esri.com>

shubham7109 changed the base branch from feature-branch/geo-compose to v.next December 13, 2023 22:00

shubham7109 changed the base branch from v.next to feature-branch/geo-compose December 13, 2023 22:00

puneet-pdx self-requested a review December 13, 2023 23:44

puneet-pdx reviewed Dec 13, 2023

View reviewed changes

prupani-7 added 3 commits December 13, 2023 16:12

Merge branch 'feature-branch/geo-compose' into pri/updateNewModuleScript

087e343

add back file

a57cbc7

rename var

ce55d2a

prupani-7 requested a review from puneet-pdx December 14, 2023 00:22

prupani-7 added 2 commits December 13, 2023 16:44

jar file

f3d8f68

delete unwanted

40c1f99

puneet-pdx approved these changes Dec 14, 2023

View reviewed changes

prupani-7 merged commit f19b6f6 into feature-branch/geo-compose Dec 14, 2023
1 check passed

prupani-7 deleted the pri/updateNewModuleScript branch December 14, 2023 01:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update new module script to use geo-compose toolkit component #148

update new module script to use geo-compose toolkit component #148

prupani-7 commented Dec 6, 2023

shubham7109 left a comment

shubham7109 Dec 11, 2023

prupani-7 Dec 12, 2023

shubham7109 Dec 11, 2023

prupani-7 commented Dec 12, 2023

shubham7109 left a comment

shubham7109 commented Dec 13, 2023

puneet-pdx Dec 13, 2023

prupani-7 Dec 14, 2023 •

edited

Loading

puneet-pdx Dec 13, 2023

prupani-7 Dec 14, 2023

puneet-pdx Dec 13, 2023

prupani-7 commented Dec 14, 2023 •

edited

Loading

prupani-7 commented Dec 14, 2023 •

edited

Loading

	implementation(platform("com.esri:arcgis-maps-kotlin-toolkit-bom:200.3.0-1"))
	implementation(platform("com.esri:arcgis-maps-kotlin-toolkit-bom:$arcgisToolkitVersion"))

		@@ -111,9 +110,6 @@ private void createFilesAndFolders() {

		File composeComponentsDir = new File(packageDirectory + "/components");

update new module script to use geo-compose toolkit component #148

update new module script to use geo-compose toolkit component #148

Conversation

prupani-7 commented Dec 6, 2023

Description

Links and Data

What To Review

How to Test

shubham7109 left a comment

Choose a reason for hiding this comment

shubham7109 Dec 11, 2023

Choose a reason for hiding this comment

prupani-7 Dec 12, 2023

Choose a reason for hiding this comment

shubham7109 Dec 11, 2023

Choose a reason for hiding this comment

prupani-7 commented Dec 12, 2023

shubham7109 left a comment

Choose a reason for hiding this comment

shubham7109 commented Dec 13, 2023

puneet-pdx Dec 13, 2023

Choose a reason for hiding this comment

prupani-7 Dec 14, 2023 • edited Loading

Choose a reason for hiding this comment

puneet-pdx Dec 13, 2023

Choose a reason for hiding this comment

prupani-7 Dec 14, 2023

Choose a reason for hiding this comment

puneet-pdx Dec 13, 2023

Choose a reason for hiding this comment

prupani-7 commented Dec 14, 2023 • edited Loading

prupani-7 commented Dec 14, 2023 • edited Loading

prupani-7 Dec 14, 2023 •

edited

Loading

prupani-7 commented Dec 14, 2023 •

edited

Loading

prupani-7 commented Dec 14, 2023 •

edited

Loading