dev: remove cargo clippy pre-commit hook #2703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Developers can run `just lint` to check for clippy errors in all crates. The project has grown very large and as a result running cargo clippy can take several minutes and that's annoying. It's especially bad when an editor IDE is used to commit that doesn't show what's going in pre-commit hooks. Developers are tempted to run with `--no-verify` which disables all checks. And may then require multiple fixup commits to get CI to pass. The other checks however are all pretty fast or only run when rarely modified files are modified. Therefore I think removing cargo clippy will make the pre-commit hooks more usable again.
sveitser
requested review from
philippecamacho,
ImJeremyHe,
jbearer,
tbro and
imabdulbasit
as code owners
imabdulbasit
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developers can run
just lintto check for clippy errors in all crates.The project has grown very large and as a result running cargo clippy can take several minutes and that's annoying. It's especially bad when an editor IDE is used to commit that doesn't show what's going in pre-commit hooks. Developers are tempted to run with
--no-verifywhich disables all checks. And may then require multiple fixup commits to get CI to pass. The other checks however are all pretty fast or only run when rarely modified files are modified. Therefore I think removing cargo clippy will make the pre-commit hooks more usable again.