vacuum sqlite after pruning data #2697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imabdulbasit
requested review from
philippecamacho,
ImJeremyHe,
sveitser,
jbearer and
tbro
as code owners
imabdulbasit
force-pushed
the
ab/vacuum-sqlite
branch
from
16e5608 to
577e981
Compare
rob-maron
approved these changes
Feb 27, 2025
imabdulbasit
commented
Feb 27, 2025
| { | ||
| let mut conn = self.pool().acquire().await?; | ||
| query("VACUUM").execute(conn.as_mut()).await?; | ||
| conn.close().await?; |
There was a problem hiding this comment.
think this get closed after drop but I am not sure
rob-maron
pushed a commit
that referenced
this pull request
Feb 28, 2025
* vaccum sqlite database * use pruned height table for opening sqlite write txn * move vacuum after each batch delete
sveitser
pushed a commit
that referenced
this pull request
Mar 7, 2025
* Init new file and a couple of setup lines * working test for QC init case * new test passing * minimal third test * complete test * remove unused code * test negative case * move the view to use node 2 as the leaderg * remove dead code * receive instead * disambiguate a couple of lines, remove commented out code * grammar * Fix tests * improve test correctness * remove duplication in expression * fix naming * permute ordering 6 ways * clarify comment * fix doc comment * fix failing case, remove unsafe code * add a comment * fix names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.