make query module optional #2696
Merged
+193
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imabdulbasit
requested review from
philippecamacho,
ImJeremyHe,
sveitser,
jbearer and
tbro
as code owners
rob-maron
approved these changes
Feb 27, 2025
rob-maron
pushed a commit
that referenced
this pull request
Feb 28, 2025
sveitser
pushed a commit
that referenced
this pull request
Mar 7, 2025
This is extremely useful for downstream testing. For example, many tests in the query service rely on a timestamp. Without this change, we would have to implement our own test types or implement something very unrealistic (like always getting the current time every time we get the timestamp for the same header). This is also pretty realistic, as any real application will probably timestamp its blocks, and it demonstrates getting inputs in `Header::new` from the outside world (ie the hardware clock) in addition to just the inputs which are passed in, which is good for example purposes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes query module optional again, and adds back status and catchup module.