Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a default port to ESPRESSO_SEQUENCER_API_PORT #2644

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

Ancient123
Copy link
Member

To reduce the number of required options to launch a basic sequencer docker, we want to set ESPRESSO_SEQUENCER_API_PORT to a sane default. Port 80 chosen since the API communicates over http.

@jparr721
Copy link
Contributor

Won't this require sudo to bind on startup?

@Ancient123
Copy link
Member Author

Or it can be set to a different port. This shouldn't have a negative effect on docker binding either.

We could make it 8080 instead if we think that is better

@tbro
Copy link
Contributor

tbro commented Feb 20, 2025

Slight preference for 8080 over 80.

@Ancient123 Ancient123 force-pushed the ancients/default-port branch 2 times, most recently from 6126e81 to 01d763a Compare February 20, 2025 21:40
@Ancient123 Ancient123 force-pushed the ancients/default-port branch from 01d763a to 38be3d2 Compare February 24, 2025 15:44
@Ancient123 Ancient123 merged commit ab75816 into main Feb 25, 2025
52 checks passed
@Ancient123 Ancient123 deleted the ancients/default-port branch February 25, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants