Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix builder API verisoning #2613

Closed
wants to merge 1 commit into from
Closed

Fix builder API verisoning #2613

wants to merge 1 commit into from

Conversation

rob-maron
Copy link
Contributor

No description provided.

deepugami pushed a commit to deepugami/espresso-sequencer that referenced this pull request Feb 13, 2025
@dependabot
Bump syn from 2.0.49 to 2.0.50 (EspressoSystems#2613)
7c66fa9 
Bumps [syn](https://github.com/dtolnay/syn) from 2.0.49 to 2.0.50.
- [Release notes](https://github.com/dtolnay/syn/releases)
- [Commits](dtolnay/syn@2.0.49...2.0.50)

---
updated-dependencies:
- dependency-name: syn
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@rob-maron rob-maron requested a review from ss-es February 17, 2025 14:37
ss-es
ss-es approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@ss-es ss-es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you rerun CI just to make sure the builder test that's failing is just flakiness?

ss-es
ss-es requested changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@ss-es ss-es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, it looks like the test failed 6 times in a row -- I'm guessing it's not just flakiness

@rob-maron rob-maron closed this Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ss-es ss-es ss-es requested changes

@philippecamacho philippecamacho Awaiting requested review from philippecamacho

@ImJeremyHe ImJeremyHe Awaiting requested review from ImJeremyHe

@sveitser sveitser Awaiting requested review from sveitser sveitser is a code owner

@jbearer jbearer Awaiting requested review from jbearer jbearer is a code owner

@tbro tbro Awaiting requested review from tbro tbro is a code owner

@imabdulbasit imabdulbasit Awaiting requested review from imabdulbasit imabdulbasit is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rob-maron @ss-es