add schema validation for relgen #6345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josh-heyer
force-pushed
the
automation/josh/validation-for-relgen
branch
from
d9b8878 to
8bba8ca
Compare
djw-m
force-pushed
the
automation/josh/validation-for-relgen
branch
3 times, most recently
from
4db8c43 to
7ff304e
Compare
djw-m
approved these changes
Jan 9, 2025
also: - show warnings / errors in GitHub when running from Actions - allow running from npm
Signed-off-by: Dj Walker-Morgan <dj.walker-morgan@enterprisedb.com>
josh-heyer
force-pushed
the
automation/josh/validation-for-relgen
branch
from
7ff304e to
eade724
Compare
josh-heyer
added
the
deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed?
This may not be the nicest way of handling errors, but it has the distinct advantages of allowing for in-editor warnings when using VSCode, which is nicer than dealing with error messages anyway.
also:
show warnings / errors in GitHub when running from Actions
allow running from npm
Reviewing
Pull locally, then from VSCode terminal run
then
Should have clickable links to non-compliant files with vaguely relevant line and column numbers. Click them, get reasonable-ish errors shown inline.