From 6af085bf24a2793f528afbb1b527a957af284a27 Mon Sep 17 00:00:00 2001 From: Betsy Gitelman Date: Fri, 31 Jan 2025 16:04:37 -0500 Subject: [PATCH] Apply suggestions from code review --- .../docs/epas/13/epas_guide/14_edb_clone_schema.mdx | 10 +++++----- .../docs/epas/14/epas_guide/14_edb_clone_schema.mdx | 4 ++-- .../cloning_with_a_non_super_user.mdx | 7 +++---- .../cloning_with_a_non_super_user.mdx | 5 ++--- .../cloning_with_non_super_user.mdx | 10 +++++----- .../setting_up_edb_clone_schema.mdx | 2 +- 6 files changed, 18 insertions(+), 20 deletions(-) diff --git a/product_docs/docs/epas/13/epas_guide/14_edb_clone_schema.mdx b/product_docs/docs/epas/13/epas_guide/14_edb_clone_schema.mdx index ad435ababfd..59c7d012aa7 100644 --- a/product_docs/docs/epas/13/epas_guide/14_edb_clone_schema.mdx +++ b/product_docs/docs/epas/13/epas_guide/14_edb_clone_schema.mdx @@ -207,7 +207,7 @@ After creating the extensions, to create the log directory, execute the followin SELECT edb_util.create_clone_log_dir(); ``` -When successful, command returns `true`. +When successful, the command returns `true`. ### Creating the Foreign Servers and User Mappings @@ -233,7 +233,7 @@ The user mapping defines the connection and authentication information for the f **This foreign server and user mapping must be created within the database of the local server in which the cloning is to occur.** -**When invoking an EDB Clone Schema function, the database user for whom the user mapping is defined must have the required privileges and be connected to the local server .** +**When invoking an EDB Clone Schema function, the database user for whom the user mapping is defined must have the required privileges and be connected to the local server.** The following example creates the foreign server for the database containing the schema to be cloned, and to receive the cloned schema as well. @@ -307,7 +307,7 @@ The user mappings define the connection and authentication information for the f **All of these foreign servers and user mappings must be created within the target database of the target/local server.** -**When invoking an EDB Clone Schema function, the database user for whom the user mappings are defined must have the required privileges and be connected to the local server .** +**When invoking an EDB Clone Schema function, the database user for whom the user mappings are defined must have the required privileges and be connected to the local server.** The following example creates the foreign server for the local target database that is to receive the cloned schema. @@ -1163,7 +1163,7 @@ INFO: Executed command: GRANT USAGE ON FOREIGN DATA WRAPPER postgres_fdw TO "ec ### REVOKE_CLONE_SCHEMA_PRIVILEGES -You can revoke the clone schema privileges from a non-superuser using this function. +This function revokes the clone schema privileges from a non-superuser. Syntax: @@ -1219,7 +1219,7 @@ __OUTPUT__ CREATE ROLE ``` -Give CREATE privileges on the `edb` database to `forcs`: +Give CREATE privileges on the `edb` database to `forcs`: ```sql GRANT CREATE on DATABASE edb to forcs; diff --git a/product_docs/docs/epas/14/epas_guide/14_edb_clone_schema.mdx b/product_docs/docs/epas/14/epas_guide/14_edb_clone_schema.mdx index c3f35a97824..caf900e1e4e 100644 --- a/product_docs/docs/epas/14/epas_guide/14_edb_clone_schema.mdx +++ b/product_docs/docs/epas/14/epas_guide/14_edb_clone_schema.mdx @@ -1120,7 +1120,7 @@ INFO: Executed command: GRANT USAGE ON FOREIGN DATA WRAPPER postgres_fdw TO "ec ### REVOKE_CLONE_SCHEMA_PRIVILEGES -You can revoke the clone schema privileges from a non-superuser using this function. +This function revokes the clone schema privileges from a non-superuser. Syntax: @@ -1176,7 +1176,7 @@ __OUTPUT__ CREATE ROLE ``` -Give CREATE privileges on the `edb` database to `forcs`: +Give CREATE privileges on the `edb` database to `forcs`: ```sql GRANT CREATE on DATABASE edb to forcs; diff --git a/product_docs/docs/epas/15/database_administration/14_edb_clone_schema/cloning_with_a_non_super_user.mdx b/product_docs/docs/epas/15/database_administration/14_edb_clone_schema/cloning_with_a_non_super_user.mdx index 7be1e6e52f0..d184b2d0cdc 100644 --- a/product_docs/docs/epas/15/database_administration/14_edb_clone_schema/cloning_with_a_non_super_user.mdx +++ b/product_docs/docs/epas/15/database_administration/14_edb_clone_schema/cloning_with_a_non_super_user.mdx @@ -2,10 +2,9 @@ title: Cloning schema as a non-superuser --- -## Cloning schema as a non-superuser - You can clone the schema as a non-superuser. These two functions are created while creating the extension: + - `GRANT_CLONE_SCHEMA_PRIVILEGES` — Grants the privileges to clone the schema to a non-superuser. - `REVOKE_CLONE_SCHEMA_PRIVILEGES` — Revokes the privileges to clone the schema from a non-superuser. @@ -59,7 +58,7 @@ INFO: Executed command: GRANT USAGE ON FOREIGN DATA WRAPPER postgres_fdw TO "ec ### REVOKE_CLONE_SCHEMA_PRIVILEGES -You can revoke the clone schema privileges from a non-superuser using this function. +This function revokes the clone schema privileges from a non-superuser. Syntax: @@ -115,7 +114,7 @@ __OUTPUT__ CREATE ROLE ``` -Give CREATE privileges on the `edb` database to `forcs`: +Give CREATE privileges on the `edb` database to `forcs`: ```sql GRANT CREATE on DATABASE edb to forcs; diff --git a/product_docs/docs/epas/16/database_administration/14_edb_clone_schema/cloning_with_a_non_super_user.mdx b/product_docs/docs/epas/16/database_administration/14_edb_clone_schema/cloning_with_a_non_super_user.mdx index 7be1e6e52f0..8695f38a13b 100644 --- a/product_docs/docs/epas/16/database_administration/14_edb_clone_schema/cloning_with_a_non_super_user.mdx +++ b/product_docs/docs/epas/16/database_administration/14_edb_clone_schema/cloning_with_a_non_super_user.mdx @@ -2,7 +2,6 @@ title: Cloning schema as a non-superuser --- -## Cloning schema as a non-superuser You can clone the schema as a non-superuser. These two functions are created while creating the extension: @@ -59,7 +58,7 @@ INFO: Executed command: GRANT USAGE ON FOREIGN DATA WRAPPER postgres_fdw TO "ec ### REVOKE_CLONE_SCHEMA_PRIVILEGES -You can revoke the clone schema privileges from a non-superuser using this function. +This function revokes the clone schema privileges from a non-superuser. Syntax: @@ -115,7 +114,7 @@ __OUTPUT__ CREATE ROLE ``` -Give CREATE privileges on the `edb` database to `forcs`: +Give CREATE privileges on the `edb` database to `forcs`: ```sql GRANT CREATE on DATABASE edb to forcs; diff --git a/product_docs/docs/epas/17/database_administration/14_edb_clone_schema/cloning_with_non_super_user.mdx b/product_docs/docs/epas/17/database_administration/14_edb_clone_schema/cloning_with_non_super_user.mdx index b0da14053fe..abf375e8efa 100644 --- a/product_docs/docs/epas/17/database_administration/14_edb_clone_schema/cloning_with_non_super_user.mdx +++ b/product_docs/docs/epas/17/database_administration/14_edb_clone_schema/cloning_with_non_super_user.mdx @@ -7,7 +7,7 @@ You can clone the schema as a non-superuser. These two functions are created whi - `GRANT_CLONE_SCHEMA_PRIVILEGES` — Grants the privileges to clone the schema to a non-superuser. - `REVOKE_CLONE_SCHEMA_PRIVILEGES` — Revokes the privileges to clone the schema from a non-superuser. -### GRANT_CLONE_SCHEMA_PRIVILEGES +## GRANT_CLONE_SCHEMA_PRIVILEGES This function grants the clone schema privileges to a non-superuser. @@ -55,9 +55,9 @@ INFO: Executed command: GRANT USAGE ON FOREIGN DATA WRAPPER postgres_fdw TO "ec (1 row) ``` -### REVOKE_CLONE_SCHEMA_PRIVILEGES +## REVOKE_CLONE_SCHEMA_PRIVILEGES -You can revoke the clone schema privileges from a non-superuser using this function. +This function revokes the clone schema privileges from a non-superuser. Syntax: @@ -116,7 +116,7 @@ __OUTPUT__ CREATE ROLE ``` -Give CREATE privileges on the `edb` database to `forcs`: +Give CREATE privileges on the `edb` database to `forcs`: ```sql GRANT CREATE on DATABASE edb to forcs; @@ -236,7 +236,7 @@ __OUTPUT__ CREATE ROLE ``` -Give CREATE privileges on the `edb` database to `forcs`: +Give CREATE privileges on the `edb` database to `forcs`: ```sql GRANT CREATE on DATABASE edb to forcs; diff --git a/product_docs/docs/epas/17/database_administration/14_edb_clone_schema/setting_up_edb_clone_schema.mdx b/product_docs/docs/epas/17/database_administration/14_edb_clone_schema/setting_up_edb_clone_schema.mdx index 0186831b464..fcbfcee9364 100644 --- a/product_docs/docs/epas/17/database_administration/14_edb_clone_schema/setting_up_edb_clone_schema.mdx +++ b/product_docs/docs/epas/17/database_administration/14_edb_clone_schema/setting_up_edb_clone_schema.mdx @@ -32,7 +32,7 @@ Modify the `postgresql.conf` file by adding `$libdir/parallel_clone` and `$libdi shared_preload_libraries = '$libdir/dbms_pipe,$libdir/dbms_aq,$libdir/parallel_clone,$libdir/edb_job_scheduler' ``` -To have the changes take effect, restart the database server. +For the changes to take effect, you must restart the database server. ## Installing PL/Perl