Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
ebgitelman authored Jan 31, 2025
1 parent 489cf1d commit 6af085b
Show file tree
Hide file tree
Showing 6 changed files with 18 additions and 20 deletions.
10 changes: 5 additions & 5 deletions product_docs/docs/epas/13/epas_guide/14_edb_clone_schema.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ After creating the extensions, to create the log directory, execute the followin
SELECT edb_util.create_clone_log_dir();
```

When successful, command returns `true`.
When successful, the command returns `true`.

### Creating the Foreign Servers and User Mappings

Expand All @@ -233,7 +233,7 @@ The user mapping defines the connection and authentication information for the f

**This foreign server and user mapping must be created within the database of the local server in which the cloning is to occur.**

**When invoking an EDB Clone Schema function, the database user for whom the user mapping is defined must have the required privileges and be connected to the local server .**
**When invoking an EDB Clone Schema function, the database user for whom the user mapping is defined must have the required privileges and be connected to the local server.**

The following example creates the foreign server for the database containing the schema to be cloned, and to receive the cloned schema as well.

Expand Down Expand Up @@ -307,7 +307,7 @@ The user mappings define the connection and authentication information for the f

**All of these foreign servers and user mappings must be created within the target database of the target/local server.**

**When invoking an EDB Clone Schema function, the database user for whom the user mappings are defined must have the required privileges and be connected to the local server .**
**When invoking an EDB Clone Schema function, the database user for whom the user mappings are defined must have the required privileges and be connected to the local server.**

The following example creates the foreign server for the local target database that is to receive the cloned schema.

Expand Down Expand Up @@ -1163,7 +1163,7 @@ INFO: Executed command: GRANT USAGE ON FOREIGN DATA WRAPPER postgres_fdw TO "ec

### REVOKE_CLONE_SCHEMA_PRIVILEGES

You can revoke the clone schema privileges from a non-superuser using this function.
This function revokes the clone schema privileges from a non-superuser.

Syntax:

Expand Down Expand Up @@ -1219,7 +1219,7 @@ __OUTPUT__
CREATE ROLE
```

Give CREATE privileges on the `edb` database to `forcs`:
Give CREATE privileges on the `edb` database to `forcs`:

```sql
GRANT CREATE on DATABASE edb to forcs;
Expand Down
4 changes: 2 additions & 2 deletions product_docs/docs/epas/14/epas_guide/14_edb_clone_schema.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -1120,7 +1120,7 @@ INFO: Executed command: GRANT USAGE ON FOREIGN DATA WRAPPER postgres_fdw TO "ec

### REVOKE_CLONE_SCHEMA_PRIVILEGES

You can revoke the clone schema privileges from a non-superuser using this function.
This function revokes the clone schema privileges from a non-superuser.

Syntax:

Expand Down Expand Up @@ -1176,7 +1176,7 @@ __OUTPUT__
CREATE ROLE
```

Give CREATE privileges on the `edb` database to `forcs`:
Give CREATE privileges on the `edb` database to `forcs`:

```sql
GRANT CREATE on DATABASE edb to forcs;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,9 @@
title: Cloning schema as a non-superuser
---

## Cloning schema as a non-superuser

You can clone the schema as a non-superuser. These two functions are created while creating the extension:


- `GRANT_CLONE_SCHEMA_PRIVILEGES` — Grants the privileges to clone the schema to a non-superuser.
- `REVOKE_CLONE_SCHEMA_PRIVILEGES` — Revokes the privileges to clone the schema from a non-superuser.

Expand Down Expand Up @@ -59,7 +58,7 @@ INFO: Executed command: GRANT USAGE ON FOREIGN DATA WRAPPER postgres_fdw TO "ec

### REVOKE_CLONE_SCHEMA_PRIVILEGES

You can revoke the clone schema privileges from a non-superuser using this function.
This function revokes the clone schema privileges from a non-superuser.

Syntax:

Expand Down Expand Up @@ -115,7 +114,7 @@ __OUTPUT__
CREATE ROLE
```

Give CREATE privileges on the `edb` database to `forcs`:
Give CREATE privileges on the `edb` database to `forcs`:

```sql
GRANT CREATE on DATABASE edb to forcs;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
title: Cloning schema as a non-superuser
---

## Cloning schema as a non-superuser

You can clone the schema as a non-superuser. These two functions are created while creating the extension:

Expand Down Expand Up @@ -59,7 +58,7 @@ INFO: Executed command: GRANT USAGE ON FOREIGN DATA WRAPPER postgres_fdw TO "ec

### REVOKE_CLONE_SCHEMA_PRIVILEGES

You can revoke the clone schema privileges from a non-superuser using this function.
This function revokes the clone schema privileges from a non-superuser.

Syntax:

Expand Down Expand Up @@ -115,7 +114,7 @@ __OUTPUT__
CREATE ROLE
```

Give CREATE privileges on the `edb` database to `forcs`:
Give CREATE privileges on the `edb` database to `forcs`:

```sql
GRANT CREATE on DATABASE edb to forcs;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ You can clone the schema as a non-superuser. These two functions are created whi
- `GRANT_CLONE_SCHEMA_PRIVILEGES` — Grants the privileges to clone the schema to a non-superuser.
- `REVOKE_CLONE_SCHEMA_PRIVILEGES` — Revokes the privileges to clone the schema from a non-superuser.

### GRANT_CLONE_SCHEMA_PRIVILEGES
## GRANT_CLONE_SCHEMA_PRIVILEGES

This function grants the clone schema privileges to a non-superuser.

Expand Down Expand Up @@ -55,9 +55,9 @@ INFO: Executed command: GRANT USAGE ON FOREIGN DATA WRAPPER postgres_fdw TO "ec
(1 row)
```

### REVOKE_CLONE_SCHEMA_PRIVILEGES
## REVOKE_CLONE_SCHEMA_PRIVILEGES

You can revoke the clone schema privileges from a non-superuser using this function.
This function revokes the clone schema privileges from a non-superuser.

Syntax:

Expand Down Expand Up @@ -116,7 +116,7 @@ __OUTPUT__
CREATE ROLE
```

Give CREATE privileges on the `edb` database to `forcs`:
Give CREATE privileges on the `edb` database to `forcs`:

```sql
GRANT CREATE on DATABASE edb to forcs;
Expand Down Expand Up @@ -236,7 +236,7 @@ __OUTPUT__
CREATE ROLE
```

Give CREATE privileges on the `edb` database to `forcs`:
Give CREATE privileges on the `edb` database to `forcs`:

```sql
GRANT CREATE on DATABASE edb to forcs;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ Modify the `postgresql.conf` file by adding `$libdir/parallel_clone` and `$libdi
shared_preload_libraries = '$libdir/dbms_pipe,$libdir/dbms_aq,$libdir/parallel_clone,$libdir/edb_job_scheduler'
```

To have the changes take effect, restart the database server.
For the changes to take effect, you must restart the database server.

## Installing PL/Perl

Expand Down

0 comments on commit 6af085b

Please sign in to comment.