Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add orientation specific timeout handling #229

Merged
merged 1 commit into from
Mar 6, 2025
Merged

add orientation specific timeout handling #229

merged 1 commit into from
Mar 6, 2025
+6 −1

Conversation

NicoHinderling
Copy link
Collaborator

@NicoHinderling NicoHinderling commented Mar 6, 2025 •
edited
Loading

Catch this error

Error Domain=BSActionErrorDomain Code=2 \"(null)\" UserInfo={BSErrorCodeDescription=timeout}

and treat it as a formatted RenderingError.

Worth noting that in situations where we saw this error, it occurred sporadically

@NicoHinderling NicoHinderling merged commit 3e40357 into main Mar 6, 2025
7 checks passed
@NicoHinderling NicoHinderling deleted the add-specific-orientation-timeout-handling branch March 6, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Itaybre Itaybre Itaybre approved these changes

@noahsmartin noahsmartin noahsmartin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NicoHinderling @Itaybre @noahsmartin