Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update attachment name #227

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Update attachment name #227

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions Sources/SnapshottingTests/SnapshotTest.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,15 +68,16 @@ open class SnapshotTest: PreviewBaseTest, PreviewFilters {
/// This method renders the specified preview using the appropriate rendering strategy,
/// creates a snapshot image, and attaches it to the test results.
///
/// - Parameter preview: A `DiscoveredPreviewAndIndex` object representing the preview to be tested.
/// - Parameter discoveredPreview: A `DiscoveredPreviewAndIndex` object representing the preview to be tested.
@MainActor
override func testPreview(_ preview: DiscoveredPreviewAndIndex) {
let previewType = Self.previews.first { $0.typeName == preview.preview.typeName }
guard let preview = previewType?.previews[preview.index] else {
XCTFail("Preview not found")
override func testPreview(_ discoveredPreview: DiscoveredPreviewAndIndex) {
let previewType = Self.previews.first { $0.typeName == discoveredPreview.preview.typeName }
guard let previewType = previewType else {
XCTFail("Preview type not found")
return
}

let preview = previewType.previews[discoveredPreview.index]
var result: SnapshotResult? = nil
let expectation = XCTestExpectation()
Self.renderingStrategy.render(preview: preview) { snapshotResult in
Expand All @@ -88,9 +89,14 @@ open class SnapshotTest: PreviewBaseTest, PreviewFilters {
XCTFail("Did not render")
return
}

var typeFileName = previewType.displayName
if let fileId = previewType.fileID, let lineNumber = previewType.line {
typeFileName = "\(fileId):\(lineNumber)"
}
do {
let attachment = try XCTAttachment(image: result.image.get())
attachment.name = preview.displayName
attachment.name = "\(typeFileName)_\(preview.displayName ?? String(discoveredPreview.index))"
attachment.lifetime = .keepAlways
add(attachment)
} catch {
Expand Down