Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to likelihood map pre-calculation performance for large maps #471

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

glpuga
Copy link
Collaborator

@glpuga glpuga commented Feb 11, 2025

Proposed changes

Addresses #468
Also fixes #472

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

Checklist

Put an x in the boxes that apply. This is simply a reminder of what we will require before merging your code.

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

Additional comments

Anything worth mentioning to the reviewers.

@glpuga glpuga changed the title Experiments to check the performance of nearest_obstacle_distance_map Fix to likelihood map pre-calculation low performance with large maps Feb 11, 2025
@glpuga glpuga force-pushed the glpuga/nearest_obstacle_distance_map_improvements branch 4 times, most recently from e1a832c to 9ced3f5 Compare February 12, 2025 19:53
@glpuga glpuga changed the title Fix to likelihood map pre-calculation low performance with large maps Fix to likelihood map pre-calculation performance for large maps Feb 12, 2025
@glpuga glpuga marked this pull request as ready for review February 12, 2025 20:16
@glpuga glpuga force-pushed the glpuga/nearest_obstacle_distance_map_improvements branch 2 times, most recently from 44caa32 to bcbfb92 Compare February 12, 2025 21:45
Copy link
Collaborator

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Signed-off-by: Gerardo Puga <glpuga@gmail.com>
@glpuga glpuga force-pushed the glpuga/nearest_obstacle_distance_map_improvements branch from bcbfb92 to d8af096 Compare February 13, 2025 16:44
@glpuga glpuga merged commit c91454c into main Feb 13, 2025
10 checks passed
@glpuga glpuga deleted the glpuga/nearest_obstacle_distance_map_improvements branch February 13, 2025 20:59
@hidmic hidmic mentioned this pull request Feb 15, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants