Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow irregular fvar instance names #2

Merged
merged 3 commits into from
Nov 15, 2023
Merged

Conversation

yanone
Copy link
Contributor

@yanone yanone commented Nov 15, 2023

I got notified that Honk may carry irregular instance names.

I updated the files accordingly. Please merge this PR for the onboarding process to be able to pull the latest files from the repository.

Thank you.

@RosaWagner
Copy link

RosaWagner commented Nov 15, 2023

@yanone you may want to add these names and values to the STAT table for apps like MS Words to be able to display them (so in the config.yaml file)

@yanone
Copy link
Contributor Author

yanone commented Nov 15, 2023

@RosaWagner The default instance is called "Regular" in their font, whereas according to the axis registry it should be called "Default". Can it be named Regular?

@RosaWagner
Copy link

Yes, but you would need elide the 2 default values with flags: 2

@yanone
Copy link
Contributor Author

yanone commented Nov 15, 2023

🫣

@RosaWagner
Copy link

Looks good now 👍

@girish-dalvi girish-dalvi merged commit 964739f into EkType:main Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants