From 61bb94dc40da54e2e120a099cdcf3a9def76d697 Mon Sep 17 00:00:00 2001 From: William Volin Date: Wed, 18 May 2022 22:35:09 -0700 Subject: [PATCH 1/3] fixes reset bug by using pre-start lifecycle instead of bogus value --- octopath.asl | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/octopath.asl b/octopath.asl index fc71102..a65da6a 100644 --- a/octopath.asl +++ b/octopath.asl @@ -527,9 +527,8 @@ start { } reset { - if (timer.CurrentPhase == TimerPhase.Running && - current.characterIsHighlighted == 1 && - old.characterIsHighlighted == 0 && + if (old.start == 0 && + current.start == 1 && current.zoneID == 0) { return true; } From 7a47e6d3f555d4e6f9d589469f78775e0c5b0022 Mon Sep 17 00:00:00 2001 From: William Volin Date: Wed, 18 May 2022 22:52:05 -0700 Subject: [PATCH 2/3] update reset and start notes on readme --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 0296fe5..0b96025 100644 --- a/README.md +++ b/README.md @@ -43,8 +43,8 @@ The above will split when entering Noblecourt the first time. Note that you will likely need a different layout for each category, to store different autosplitter settings. Testing needed, and can possibly be improved. ### Options -- Start: Will start the timer on character selection -- Reset: If timer is running, will reset if you hover a character in New Game character selection. +- Start: Will start the timer when starting a character story +- Reset: If timer is running, will reset if you start a new character story - Split: If timer is running, will split on anything enabled in settings. ### Split Options From dec51590d42e1d41fdbc22324fdb2d24ebccfeb3 Mon Sep 17 00:00:00 2001 From: William Volin Date: Wed, 18 May 2022 16:06:39 -0700 Subject: [PATCH 3/3] remove unused isCharacterHighlighted --- octopath.asl | 4 ---- 1 file changed, 4 deletions(-) diff --git a/octopath.asl b/octopath.asl index a65da6a..f47e79f 100644 --- a/octopath.asl +++ b/octopath.asl @@ -1,7 +1,5 @@ state("Octopath_Traveler-Win64-Shipping", "Steam") { int start: 0x2B32C48, 0xE30; - int characterIsHighlighted: 0x289D268, 0x368, 0x0, 0x328; - int zoneID: 0x289D240, 0x36C; int money: 0x0289CC48, 0x370, 0x158; int gameState: 0x0289D270, 0x36C; @@ -21,8 +19,6 @@ state("Octopath_Traveler-Win64-Shipping", "Steam") { state("Octopath_Traveler-Win64-Shipping", "Xbox") { int start: 0x031C1FB0, 0x18, 0x700; - int characterIsHighlighted: 0x0302AF18, 0x240, 0x0, 0x358; - int zoneID: 0x0302AEF0, 0x244; int money: 0x0302A8E8, 0x280, 0x150; int gameState: 0x0302AF20, 0x244;