Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing collapse key #57

Closed
Philipp91 opened this issue Sep 27, 2022 · 5 comments · Fixed by #60
Closed

Missing collapse key #57

Philipp91 opened this issue Sep 27, 2022 · 5 comments · Fixed by #60
Assignees
Labels
enhancement New feature or request

Comments

@Philipp91
Copy link
Contributor

See docs: https://firebase.google.com/docs/cloud-messaging/concept-options#delivery-options

And another PHP implementation: https://github.com/Paragraph1/php-fcm/blob/b8d6fec2c5327ed8fbe09d4d1cc0b53467a340e0/src/Message.php#L151

@github-actions
Copy link

Thanks for creating your first issue on php-fcm

@AndyGaskell
Copy link
Collaborator

Thanks @Philipp91 I'll try and implement that.

I've not seen Paragraph1/php-fcm so that's handy to see how they've implemented things.

@AndyGaskell AndyGaskell self-assigned this Sep 30, 2022
@AndyGaskell AndyGaskell added the enhancement New feature or request label Sep 30, 2022
@Philipp91
Copy link
Contributor Author

Thanks. If you prefer, I can also take a stab at it. Btw, is this repository still maintained? I haven't seen a reaction to my (unrelated) PR, there are several PRs open for a while, and @EdwinHoksberg hasn't been active on GitHub for a while.

@EdwinHoksberg This may just be a coincidence (like vacation week or sth like that), in which case please disregard my comment. Though if you find yourself being less active on GitHub for whatever reasons, please consider giving @AndyGaskell or someone else who contributes a lot enough write access to this repository to allow merging PRs -- not sure about releases.

@AndyGaskell
Copy link
Collaborator

Hi @Philipp91
Although Edwin created this project originally, he did not have time to maintain it really. So a couple of years ago he gave admin access to me and @rolinger.
While we try to keep on top of things, time commitment is always a bit of a juggling act. I need to set aside a couple of days to catch up on issues and PRs. Some parts of the project are not in my core skill set, like the type of unit testing we use, or Laravel conventions.
Any help would be greatly appreciated though :)

@rolinger
Copy link
Collaborator

rolinger commented Nov 4, 2022

@AndyGaskell - heh....set aside a couple of dsays to catch up on issues. I wish I just had a couple of hours. I try to keep up with this repo and I know advances have been made with it and how push notifications work in general - none of which I have had time to incorporate into my projects. Ugh.

Philipp91 added a commit to Philipp91/php-fcm that referenced this issue Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants