Skip to content
This repository has been archived by the owner on Jul 25, 2022. It is now read-only.

Bug: Empty commits #1

Open
EdmanJohan opened this issue Apr 8, 2022 · 1 comment
Open

Bug: Empty commits #1

EdmanJohan opened this issue Apr 8, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@EdmanJohan
Copy link
Owner

EdmanJohan commented Apr 8, 2022

I've noted that there is an issue with empty commits, but I'm hesitant to update the action until anything is said. Being after deadline and all.

The issue occurs because there are changes on TimeEdit, but they are filtered out by the code/selected filter. The action, however, goes through with the commit because it doesn't check if there are any actual changes (i.e. diff between current and new state).

I've added a fix in the corresponding repository for the action. But not pushed or bumped the version number of the GH action.

But you can see how it does what it is supposed to in, for example, the following commits:

@EdmanJohan EdmanJohan added the bug Something isn't working label Apr 8, 2022
@EdmanJohan EdmanJohan self-assigned this Apr 8, 2022
@EdmanJohan
Copy link
Owner Author

Have been hesitant to address bug, as I do not want to commit changes after submission date. But I Git does keep a history...
So refer to tag v1.0.0 and the corresponding commit 4993619.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant